This is an automated email from the ASF dual-hosted git repository. bcall pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit d963c710e9cf870c5b7c892db0f056903c51c20b Author: Walter Karas <[email protected]> AuthorDate: Fri Oct 25 16:36:51 2019 -0500 Disable tests using exceptions in MIOBufferWriter UT. (cherry picked from commit d2f6e7ef12110a6a820d2b3a5286764b00bec59c) --- .../eventsystem/unit_tests/test_MIOBufferWriter.cc | 24 +++++----------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/iocore/eventsystem/unit_tests/test_MIOBufferWriter.cc b/iocore/eventsystem/unit_tests/test_MIOBufferWriter.cc index 429bff2..30239b3 100644 --- a/iocore/eventsystem/unit_tests/test_MIOBufferWriter.cc +++ b/iocore/eventsystem/unit_tests/test_MIOBufferWriter.cc @@ -189,25 +189,11 @@ TEST_CASE("MIOBufferWriter", "[MIOBW]") REQUIRE(bw.extent() == ((iobbIdx * BlockSize) + blockUsed)); -// These tests don't work properly with clang for some reason. -#if !defined(__clang__) - - try { - bw.fill(bw.auxBufferCapacity() + 1); - REQUIRE(false); - - } catch (InkAssertExcept) { - REQUIRE(true); - } - - try { - bw.data(); - REQUIRE(false); - - } catch (InkAssertExcept) { - REQUIRE(true); - } - +// These test are disabled by default because they consistently fail on FreeBSD only, and may fail on Linux flavors +// when Leif or Alan's lumbago is hurting. +#if 0 + REQUIRE_THROWS_AS(bw.fill(bw.auxBufferCapacity() + 1), InkAssertExcept); + REQUIRE_THROWS_AS(bw.data(), InkAssertExcept); #endif }
