[trafficserver] branch master updated: KWF useless member function HttpSM::kill_this_async_hook(). (#7198)

[wkaras]

This is an automated email from the ASF dual-hosted git repository.

wkaras pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 457261c  KWF useless member function HttpSM::kill_this_async_hook(). 
(#7198)
457261c is described below

commit 457261c836dc7d8a406dbdcc73afd2fdacbf4b57
Author: Walt Karas <wka...@verizonmedia.com>
AuthorDate: Wed Sep 16 20:43:49 2020 -0500

    KWF useless member function HttpSM::kill_this_async_hook(). (#7198)
---
 proxy/http/HttpSM.cc                              | 11 +----------
 proxy/http/HttpSM.h                               |  1 -
 proxy/http/remap/unit-tests/nexthop_test_stubs.cc |  5 -----
 src/traffic_quic/traffic_quic.cc                  |  6 ------
 4 files changed, 1 insertion(+), 22 deletions(-)

diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
index c6ee656..09e5f27 100644
--- a/proxy/http/HttpSM.cc
+++ b/proxy/http/HttpSM.cc
@@ -464,16 +464,7 @@ HttpSM::state_remove_from_list(int event, void * /* data 
ATS_UNUSED */)
     HttpSMList[bucket].sm_list.remove(this);
   }
 
-  return this->kill_this_async_hook(EVENT_NONE, nullptr);
-}
-
-int
-HttpSM::kill_this_async_hook(int /* event ATS_UNUSED */, void * /* data 
ATS_UNUSED */)
-{
-  // In the base HttpSM, we don't have anything to
-  //   do here.  subclasses can override this function
-  //   to do their own asynchronous cleanup
-  // So We're now ready to finish off the state machine
+  // We're now ready to finish off the state machine
   terminate_sm         = true;
   kill_this_async_done = true;
 
diff --git a/proxy/http/HttpSM.h b/proxy/http/HttpSM.h
index 627d30a..c343d76 100644
--- a/proxy/http/HttpSM.h
+++ b/proxy/http/HttpSM.h
@@ -593,7 +593,6 @@ protected:
   bool terminate_sm         = false;
   bool kill_this_async_done = false;
   bool parse_range_done     = false;
-  virtual int kill_this_async_hook(int event, void *data);
   void kill_this();
   void update_stats();
   void transform_cleanup(TSHttpHookID hook, HttpTransformInfo *info);
diff --git a/proxy/http/remap/unit-tests/nexthop_test_stubs.cc 
b/proxy/http/remap/unit-tests/nexthop_test_stubs.cc
index ab01961..6eb2d7e 100644
--- a/proxy/http/remap/unit-tests/nexthop_test_stubs.cc
+++ b/proxy/http/remap/unit-tests/nexthop_test_stubs.cc
@@ -47,11 +47,6 @@ void
 HttpSM::set_next_state()
 {
 }
-int
-HttpSM::kill_this_async_hook(int event, void *data)
-{
-  return 0;
-}
 
 HttpVCTable::HttpVCTable(HttpSM *smp)
 {
diff --git a/src/traffic_quic/traffic_quic.cc b/src/traffic_quic/traffic_quic.cc
index 829704e..8af2146 100644
--- a/src/traffic_quic/traffic_quic.cc
+++ b/src/traffic_quic/traffic_quic.cc
@@ -301,12 +301,6 @@ HttpSM::handle_api_return()
   ink_abort("do not call stub");
 }
 
-int
-HttpSM::kill_this_async_hook(int /* event ATS_UNUSED */, void * /* data 
ATS_UNUSED */)
-{
-  return EVENT_DONE;
-}
-
 void
 HttpSM::attach_client_session(ProxyTransaction *, IOBufferReader *)
 {