[trafficserver] branch master updated: Output diags to stderr before reconfig (#9164)

[cmcfarlen]

This is an automated email from the ASF dual-hosted git repository.

cmcfarlen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 114d6befe Output diags to stderr before reconfig (#9164)
114d6befe is described below

commit 114d6befe7058c5e7ed51a8d8314662ba35cb807
Author: Chris McFarlen <ch...@mcfarlen.us>
AuthorDate: Tue Nov 8 10:00:26 2022 -0600

    Output diags to stderr before reconfig (#9164)
    
    * Output diags to stderr before reconfig
    
    Co-authored-by: Chris McFarlen <cmcfar...@apple.com>
---
 proxy/shared/DiagsConfig.cc | 5 +++++
 src/tscore/ink_cap.cc       | 8 ++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/proxy/shared/DiagsConfig.cc b/proxy/shared/DiagsConfig.cc
index 08afcbffa..3e505020d 100644
--- a/proxy/shared/DiagsConfig.cc
+++ b/proxy/shared/DiagsConfig.cc
@@ -238,6 +238,11 @@ DiagsConfig::config_diags_norecords()
     c.enabled(DiagsTagType_Action, 0);
   }
 
+  // Route all outputs to stderr by default until reconfigured with 
records.config
+  for (auto &o : c.outputs) {
+    o.to_stderr = true;
+  }
+
 #if !defined(__GNUC__)
   _diags->config = c;
 #else
diff --git a/src/tscore/ink_cap.cc b/src/tscore/ink_cap.cc
index 03b1249b5..23aeec2c5 100644
--- a/src/tscore/ink_cap.cc
+++ b/src/tscore/ink_cap.cc
@@ -278,7 +278,7 @@ RestrictCapabilities()
     if (cap_set_flag(caps, CAP_PERMITTED, 1, perm_list + i, CAP_SET) < 0) {
     } else {
       if (cap_set_proc(caps) == -1) { // it failed, back out
-        Warning("CAP_PERMITTED failed for option %d", i);
+        Debug("privileges", "CAP_PERMITTED failed for option %d", i);
       } else {
         if (cap_set_flag(caps_good, CAP_PERMITTED, 1, perm_list + i, CAP_SET) 
< 0) {
         }
@@ -294,7 +294,7 @@ RestrictCapabilities()
     if (cap_set_flag(caps, CAP_EFFECTIVE, 1, eff_list + i, CAP_SET) < 0) {
     } else {
       if (cap_set_proc(caps) == -1) { // it failed, back out
-        Warning("CAP_EFFECTIVE failed for option %d", i);
+        Debug("privileges", "CAP_EFFECTIVE failed for option %d", i);
       } else {
         if (cap_set_flag(caps_good, CAP_EFFECTIVE, 1, eff_list + i, CAP_SET) < 
0) {
         }
@@ -314,14 +314,14 @@ RestrictCapabilities()
     cap_flag_value_t val;
     if (cap_get_flag(caps_good, perm_list[i], CAP_PERMITTED, &val) < 0) {
     } else {
-      Warning("CAP_PERMITTED offiset %d is %s", i, val == CAP_SET ? "set" : 
"unset");
+      Debug("privileges", "CAP_PERMITTED offset %d is %s", i, val == CAP_SET ? 
"set" : "unset");
     }
   }
   for (int i = 0; i < EFF_CAP_COUNT; i++) {
     cap_flag_value_t val;
     if (cap_get_flag(caps_good, eff_list[i], CAP_EFFECTIVE, &val) < 0) {
     } else {
-      Warning("CAP_EFFECTIVE offiset %d is %s", i, val == CAP_SET ? "set" : 
"unset");
+      Debug("privileges", "CAP_EFFECTIVE offset %d is %s", i, val == CAP_SET ? 
"set" : "unset");
     }
   }