[trafficserver] branch master updated: Adds some casts to avoid pedantic compile warnings (#9868)

[zwoop]

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new f85880d3f8 Adds some casts to avoid pedantic compile warnings (#9868)
f85880d3f8 is described below

commit f85880d3f867d9116e8fd12f5d9ea53b5db8180d
Author: Leif Hedstrom <zw...@apache.org>
AuthorDate: Wed Jun 21 16:26:51 2023 -0600

    Adds some casts to avoid pedantic compile warnings (#9868)
---
 include/tscore/ink_mutex.h         |  4 ++--
 include/tscore/ink_rwlock.h        | 15 +++++----------
 include/tscpp/util/TsSharedMutex.h |  4 ----
 3 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/include/tscore/ink_mutex.h b/include/tscore/ink_mutex.h
index ac3e49f3cb..71f8450582 100644
--- a/include/tscore/ink_mutex.h
+++ b/include/tscore/ink_mutex.h
@@ -47,7 +47,7 @@ ink_mutex_acquire(ink_mutex *m)
 {
   int error = pthread_mutex_lock(m);
   if (unlikely(error != 0)) {
-    ink_abort("pthread_mutex_lock(%p) failed: %s (%d)", m, strerror(error), 
error);
+    ink_abort("pthread_mutex_lock(%p) failed: %s (%d)", static_cast<void 
*>(m), strerror(error), error);
   }
 }
 
@@ -56,7 +56,7 @@ ink_mutex_release(ink_mutex *m)
 {
   int error = pthread_mutex_unlock(m);
   if (unlikely(error != 0)) {
-    ink_abort("pthread_mutex_unlock(%p) failed: %s (%d)", m, strerror(error), 
error);
+    ink_abort("pthread_mutex_unlock(%p) failed: %s (%d)", static_cast<void 
*>(m), strerror(error), error);
   }
 }
 
diff --git a/include/tscore/ink_rwlock.h b/include/tscore/ink_rwlock.h
index dfc6892c16..b3bc10f367 100644
--- a/include/tscore/ink_rwlock.h
+++ b/include/tscore/ink_rwlock.h
@@ -44,12 +44,7 @@ ink_rwlock const INK_RWLOCK_INIT = 
PTHREAD_RWLOCK_INITIALIZER;
 ink_rwlock const INK_RWLOCK_INIT_NO_WRITER_STARVATION = 
PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP;
 #else
 // Testing indicates that for MacOS/Darwin and FreeBSD, pthread rwlocks always 
prevent writer starvation.
-//
 ink_rwlock const INK_RWLOCK_INIT_NO_WRITER_STARVATION = INK_RWLOCK_INIT;
-
-#if !(defined(darwin) || defined(freebsd))
-#warning "Use of ink_rwlock may result in writer starvation"
-#endif
 #endif
 
 inline void
@@ -57,7 +52,7 @@ ink_rwlock_rdlock(ink_rwlock *rw)
 {
   int error = pthread_rwlock_rdlock(rw);
   if (unlikely(error != 0)) {
-    ink_abort("pthread_rwlock_rdlock(%p) failed: %s (%d)", rw, 
strerror(error), error);
+    ink_abort("pthread_rwlock_rdlock(%p) failed: %s (%d)", static_cast<void 
*>(rw), strerror(error), error);
   }
 }
 
@@ -69,7 +64,7 @@ ink_rwlock_tryrdlock(ink_rwlock *rw)
     return false;
   }
   if (unlikely(error != 0)) {
-    ink_abort("pthread_rwlock_tryrdlock(%p) failed: %s (%d)", rw, 
strerror(error), error);
+    ink_abort("pthread_rwlock_tryrdlock(%p) failed: %s (%d)", static_cast<void 
*>(rw), strerror(error), error);
   }
   return true;
 }
@@ -79,7 +74,7 @@ ink_rwlock_wrlock(ink_rwlock *rw)
 {
   int error = pthread_rwlock_wrlock(rw);
   if (unlikely(error != 0)) {
-    ink_abort("pthread_rwlock_wrlock(%p) failed: %s (%d)", rw, 
strerror(error), error);
+    ink_abort("pthread_rwlock_wrlock(%p) failed: %s (%d)", static_cast<void 
*>(rw), strerror(error), error);
   }
 }
 
@@ -91,7 +86,7 @@ ink_rwlock_trywrlock(ink_rwlock *rw)
     return false;
   }
   if (unlikely(error != 0)) {
-    ink_abort("pthread_rwlock_trywrlock(%p) failed: %s (%d)", rw, 
strerror(error), error);
+    ink_abort("pthread_rwlock_trywrlock(%p) failed: %s (%d)", static_cast<void 
*>(rw), strerror(error), error);
   }
   return true;
 }
@@ -101,6 +96,6 @@ ink_rwlock_unlock(ink_rwlock *rw)
 {
   int error = pthread_rwlock_unlock(rw);
   if (unlikely(error != 0)) {
-    ink_abort("pthread_rwlock_unlock(%p) failed: %s (%d)", rw, 
strerror(error), error);
+    ink_abort("pthread_rwlock_unlock(%p) failed: %s (%d)", static_cast<void 
*>(rw), strerror(error), error);
   }
 }
diff --git a/include/tscpp/util/TsSharedMutex.h 
b/include/tscpp/util/TsSharedMutex.h
index 36e3b15083..43df4921fb 100644
--- a/include/tscpp/util/TsSharedMutex.h
+++ b/include/tscpp/util/TsSharedMutex.h
@@ -176,10 +176,6 @@ private:
   // Testing indicates that for MacOS/Darwin and FreeBSD, pthread rwlocks 
always prevent writer starvation.
   //
   pthread_rwlock_t _lock = PTHREAD_RWLOCK_INITIALIZER;
-
-#if !(defined(darwin) || defined(freebsd))
-#warning "Use of ts::shared_mutex may result in writer starvation"
-#endif
 #endif
 
   static void