This is an automated email from the ASF dual-hosted git repository.
bneradt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new 3003c27b24 Shutdown tests: update backing sleep command to 10 (#10077)
3003c27b24 is described below
commit 3003c27b24986aa4b5b0f764ec48452a7d311bb9
Author: Brian Neradt <[email protected]>
AuthorDate: Mon Jul 24 10:38:32 2023 -0500
Shutdown tests: update backing sleep command to 10 (#10077)
The Ready conditions for some await processes waited upon the existence
of a log entry before continuing. This works fine, but the process
behind some of them was a 1 second sleep. If the sleep finished before
the file existed, which should be rare for these tests but possible, the
test would fail because the process finished before the process was
"ready". This updates the backing sleep commands to 10 second sleeps
which should afford plenty of time for the watch processes to see their
file content. This may make these tests more reliable in CI.
---
tests/gold_tests/remap/remap_load_empty_failure.test.py | 2 +-
tests/gold_tests/shutdown/emergency.test.py | 2 +-
tests/gold_tests/shutdown/fatal.test.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/gold_tests/remap/remap_load_empty_failure.test.py
b/tests/gold_tests/remap/remap_load_empty_failure.test.py
index 47a1b494d2..224011b01d 100644
--- a/tests/gold_tests/remap/remap_load_empty_failure.test.py
+++ b/tests/gold_tests/remap/remap_load_empty_failure.test.py
@@ -33,7 +33,7 @@ tr = Test.AddTestRun("test")
# before it detects the log message. So we add a separate process that waits
# upon the log message.
watcher = Test.Processes.Process("watcher")
-watcher.Command = "sleep 1"
+watcher.Command = "sleep 10"
watcher.Ready = When.FileContains(ts.Disk.diags_log.Name, "remap.config failed
to load")
watcher.StartBefore(ts)
diff --git a/tests/gold_tests/shutdown/emergency.test.py
b/tests/gold_tests/shutdown/emergency.test.py
index 3f4a8027c0..cea9107ef5 100644
--- a/tests/gold_tests/shutdown/emergency.test.py
+++ b/tests/gold_tests/shutdown/emergency.test.py
@@ -47,7 +47,7 @@ tr = Test.AddTestRun()
# before it detects the log message. So we add a separate process that waits
# upon the log message.
watcher = Test.Processes.Process("watcher")
-watcher.Command = "sleep 1"
+watcher.Command = "sleep 10"
watcher.Ready = When.FileContains(ts.Disk.diags_log.Name, "testing emergency
shutdown")
watcher.StartBefore(ts)
diff --git a/tests/gold_tests/shutdown/fatal.test.py
b/tests/gold_tests/shutdown/fatal.test.py
index 258876e193..4ffe083346 100644
--- a/tests/gold_tests/shutdown/fatal.test.py
+++ b/tests/gold_tests/shutdown/fatal.test.py
@@ -47,7 +47,7 @@ tr = Test.AddTestRun()
# before it detects the log message. So we add a separate process that waits
# upon the log message.
watcher = Test.Processes.Process("watcher")
-watcher.Command = "sleep 1"
+watcher.Command = "sleep 10"
watcher.Ready = When.FileContains(ts.Disk.diags_log.Name, "testing fatal
shutdown")
watcher.StartBefore(ts)
