This is an automated email from the ASF dual-hosted git repository.
bneradt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new 64a96980da fix KeyEqual param for ConnectingIpPool declaration (#10157)
64a96980da is described below
commit 64a96980da338b08da38998280004dc25246e035
Author: Ashi Wang <[email protected]>
AuthorDate: Tue Aug 8 02:26:13 2023 +0800
fix KeyEqual param for ConnectingIpPool declaration (#10157)
The 4th parameter, KeyEqual, is missing in ConnectingIpPool declaration,
which may lead to the comparison of two IpEndpoint object won't work as we
expected. That is, the default one is unlikely to work with sockaddr type.
In another way, IpHelper contains the compare operator for IpEndpoint type,
so IpHelper should be used as the KeyEqual parameter of ConnectingIpPool
declaration.
---
proxy/http/ConnectingEntry.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxy/http/ConnectingEntry.h b/proxy/http/ConnectingEntry.h
index c63a5a33a9..f58c85f330 100644
--- a/proxy/http/ConnectingEntry.h
+++ b/proxy/http/ConnectingEntry.h
@@ -70,7 +70,7 @@ struct IpHelper {
}
};
-using ConnectingIpPool = std::unordered_multimap<IpEndpoint, ConnectingEntry
*, IpHelper>;
+using ConnectingIpPool = std::unordered_multimap<IpEndpoint, ConnectingEntry
*, IpHelper, IpHelper>;
/** Represents the set of connections to an origin. */
class ConnectingPool
