(trafficserver) branch master updated: Remove noisy retransmit Note messages (#11225)

[bneradt]

This is an automated email from the ASF dual-hosted git repository.

bneradt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new c0a42a6a54 Remove noisy retransmit Note messages (#11225)
c0a42a6a54 is described below

commit c0a42a6a54de0b8d726d5cab3bbe304e611eb078
Author: Brian Neradt <brian.ner...@gmail.com>
AuthorDate: Mon Apr 8 14:23:27 2024 -0500

    Remove noisy retransmit Note messages (#11225)
    
    When working on the patch for #11143, I accidentally left in some Note
    log messages that should have been cleaned up before I merged in the
    changes. This removes those noisy Note messages.
---
 src/proxy/http2/Http2CommonSession.cc   | 1 -
 src/proxy/http2/Http2ConnectionState.cc | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/src/proxy/http2/Http2CommonSession.cc 
b/src/proxy/http2/Http2CommonSession.cc
index 7581c47826..1c541ba94a 100644
--- a/src/proxy/http2/Http2CommonSession.cc
+++ b/src/proxy/http2/Http2CommonSession.cc
@@ -159,7 +159,6 @@ Http2CommonSession::xmit(const Http2TxFrame &frame, bool 
flush)
     if (this->_pending_sending_data_size >= this->_write_size_threshold) {
       flush = true;
     } else {
-      Note("Calling schedule_transmit because write threshold is not 
exceeded.");
       // Observe that schedule_transmit will only schedule the first time we
       // don't flush because the threshold is not met.
       
this->connection_state.schedule_retransmit(HRTIME_MSECONDS(Http2::write_time_threshold));
diff --git a/src/proxy/http2/Http2ConnectionState.cc 
b/src/proxy/http2/Http2ConnectionState.cc
index ca50283611..9bb38b097a 100644
--- a/src/proxy/http2/Http2ConnectionState.cc
+++ b/src/proxy/http2/Http2ConnectionState.cc
@@ -1489,7 +1489,6 @@ Http2ConnectionState::main_event_handler(int event, void 
*edata)
   case HTTP2_SESSION_EVENT_XMIT: {
     REMEMBER(event, this->recursion);
     SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
-    Note("Flushing due to XMIT event");
     this->session->flush();
   } break;
 
@@ -2100,8 +2099,6 @@ Http2ConnectionState::schedule_retransmit(ink_hrtime t)
   SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
 
   if (retransmit_event == nullptr) {
-    Note("Scheduling retransmit in %" PRId64 "ms", t / HRTIME_MSECOND);
-
     SET_HANDLER(&Http2ConnectionState::main_event_handler);
     retransmit_event = this_ethread()->schedule_in((Continuation *)this, t, 
HTTP2_SESSION_EVENT_XMIT);
   }