This is an automated email from the ASF dual-hosted git repository.
dmeden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new fdbda82e85 jsonrpc: small cleanup. (#11236)
fdbda82e85 is described below
commit fdbda82e85d9f8177f0add02f4c14485c6ebf4bf
Author: Damian Meden <dme...@apache.org>
AuthorDate: Thu Apr 11 09:43:09 2024 +0200
jsonrpc: small cleanup. (#11236)
Remove come commented out code and fix some comments.
---
src/mgmt/rpc/jsonrpc/JsonRPCManager.cc | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/mgmt/rpc/jsonrpc/JsonRPCManager.cc
b/src/mgmt/rpc/jsonrpc/JsonRPCManager.cc
index dbe695934b..3747b843c1 100644
--- a/src/mgmt/rpc/jsonrpc/JsonRPCManager.cc
+++ b/src/mgmt/rpc/jsonrpc/JsonRPCManager.cc
@@ -291,11 +291,8 @@
JsonRPCManager::Dispatcher::InternalHandler::invoke(specs::RPCRequestInfo const
std::unique_lock<std::mutex>
lock(g_rpcHandlingMutex);
g_rpcHandlingCompletion.wait(lock, []() {
return g_rpcHandlerProcessingCompleted; });
g_rpcHandlerProcessingCompleted = false;
- // seems to be done, set the response. As the
response data is a swoc::Rv this will handle both,
- // error and non error cases.
+ // swoc::Rv this will handle both, error and
success cases.
ret = std::move(g_rpcHandlerResponseData);
- // clean up the shared data.
- //
g_rpcHandlerResponseData.clear(); // moved so no cleanup?
lock.unlock();
}},
this->_func);
