This is an automated email from the ASF dual-hosted git repository. cmcfarlen pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 8d13458baaaecc514ff189cafe22fb2ee3eb9e66 Author: Damian Meden <[email protected]> AuthorDate: Tue May 7 10:17:26 2024 +0200 Fix some warnings from libswoc when building on FreeBSD 13.1. (#11324) (cherry picked from commit c3ac4b74c1b3fa6a07686699e25e6bec9e7e18b7) --- lib/swoc/unit_tests/ex_bw_format.cc | 2 -- lib/swoc/unit_tests/test_TextView.cc | 3 --- lib/swoc/unit_tests/test_bw_format.cc | 1 - lib/swoc/unit_tests/test_ip.cc | 1 - lib/swoc/unit_tests/test_range.cc | 1 - 5 files changed, 8 deletions(-) diff --git a/lib/swoc/unit_tests/ex_bw_format.cc b/lib/swoc/unit_tests/ex_bw_format.cc index 4291bd6fa3..fa33238055 100644 --- a/lib/swoc/unit_tests/ex_bw_format.cc +++ b/lib/swoc/unit_tests/ex_bw_format.cc @@ -463,8 +463,6 @@ C_Format::capture(BufferWriter &, Spec const &spec, std::any const &value) { // C_Format parsing bool C_Format::operator()(std::string_view &literal, Spec &spec) { - TextView parsed; - // clean up any old business from a previous specifier. if (_prec_p) { spec._type = Spec::CAPTURE_TYPE; diff --git a/lib/swoc/unit_tests/test_TextView.cc b/lib/swoc/unit_tests/test_TextView.cc index ebeb6c23a7..20c1797deb 100644 --- a/lib/swoc/unit_tests/test_TextView.cc +++ b/lib/swoc/unit_tests/test_TextView.cc @@ -22,10 +22,8 @@ TEST_CASE("TextView Constructor", "[libswoc][TextView]") { static const std::string base = "Evil Dave Rulez!"; unsigned ux = base.size(); TextView tv(base); - TextView a{"Evil Dave Rulez"}; TextView b{base.data(), base.size()}; TextView c{std::string_view(base)}; - constexpr TextView d{"Grigor!"sv}; TextView e{base.data(), 15}; TextView f(base.data(), 15); TextView u{base.data(), ux}; @@ -188,7 +186,6 @@ TEST_CASE("TextView Affixes", "[libswoc][TextView]") { TextView tv3 = "abcdefg:gfedcba"; left = tv3; right = left.split_suffix_at(";:,"); - TextView pre{tv3}, post{pre.split_suffix(7)}; REQUIRE(right.size() == 7); REQUIRE(left.size() == 7); REQUIRE(left == "abcdefg"); diff --git a/lib/swoc/unit_tests/test_bw_format.cc b/lib/swoc/unit_tests/test_bw_format.cc index 4f98abc66e..dc3169a98d 100644 --- a/lib/swoc/unit_tests/test_bw_format.cc +++ b/lib/swoc/unit_tests/test_bw_format.cc @@ -38,7 +38,6 @@ TEST_CASE("bwprint basics", "[bwprint]") { swoc::LocalBufferWriter<256> bw; std::string_view fmt1{"Some text"sv}; swoc::bwf::Format fmt2("left >{0:<9}< right >{0:>9}< center >{0:^9}<"); - std::string_view text{"0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"}; static const swoc::bwf::Format bad_arg_fmt{"{{BAD_ARG_INDEX:{} of {}}}"}; bw.print(fmt1); diff --git a/lib/swoc/unit_tests/test_ip.cc b/lib/swoc/unit_tests/test_ip.cc index 2c7aa7ce39..d240f97d26 100644 --- a/lib/swoc/unit_tests/test_ip.cc +++ b/lib/swoc/unit_tests/test_ip.cc @@ -1251,7 +1251,6 @@ TEST_CASE("IPSpace Edge", "[libswoc][ipspace][edge]") { auto spot = cspace.find(a1); static_assert(std::is_same_v<Space::const_iterator, decltype(spot)>); auto &v1 = *spot; - auto &p1 = get<1>(v1); auto const iter = cspace.find(a1); if (auto &&[r, p] = *iter; !r.empty()) { diff --git a/lib/swoc/unit_tests/test_range.cc b/lib/swoc/unit_tests/test_range.cc index 51e629d036..30c9064a65 100644 --- a/lib/swoc/unit_tests/test_range.cc +++ b/lib/swoc/unit_tests/test_range.cc @@ -13,7 +13,6 @@ using namespace swoc::literals; using range_t = swoc::DiscreteRange<unsigned>; TEST_CASE("Discrete Range", "[libswoc][range]") { - range_t none; // empty range. range_t single{56}; range_t r1{56, 100}; range_t r2{101, 200};
