This is an automated email from the ASF dual-hosted git repository.
jvanderzee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new 1acb09f631 Remove global `-Wno-unused-parameter` warning suppression
(#11515)
1acb09f631 is described below
commit 1acb09f631db05ed9f0203b0030382eb600cc9d5
Author: Pavel Vazharov <[email protected]>
AuthorDate: Tue Jul 9 19:16:53 2024 +0300
Remove global `-Wno-unused-parameter` warning suppression (#11515)
Add the suppression to wasm/lib/CMakeLists.txt because the source code
there can't be modified but there are two unused parameters in
signature_util.cc
---
CMakeLists.txt | 2 +-
plugins/experimental/wasm/lib/CMakeLists.txt | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 17d10987cc..35c627f348 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -597,7 +597,7 @@ add_subdirectory(lib)
# Keep this after lib because lib is made up of third party libraries, so if
# there are warnings, we can't do anything about it.
# Note: -DCMAKE_COMPILE_WARNING_AS_ERROR=ON will turn warnings into errors.
-add_compile_options(-pipe -Wall -Wextra -Wno-unused-parameter)
+add_compile_options(-pipe -Wall -Wextra)
add_compile_options(
"$<$<COMPILE_LANGUAGE:CXX>:-Wno-noexcept-type;-Wsuggest-override;-Wno-vla-extension;-fno-strict-aliasing>"
)
diff --git a/plugins/experimental/wasm/lib/CMakeLists.txt
b/plugins/experimental/wasm/lib/CMakeLists.txt
index a8f51447ba..be158adcad 100644
--- a/plugins/experimental/wasm/lib/CMakeLists.txt
+++ b/plugins/experimental/wasm/lib/CMakeLists.txt
@@ -32,6 +32,7 @@ if(wamr_FOUND)
endif()
add_library(wasmlib STATIC ${CC_FILES})
+target_compile_options(wasmlib PUBLIC -Wno-unused-parameter)
if(wamr_FOUND)
target_compile_options(wasmlib PRIVATE -Wno-missing-field-initializers)
target_link_libraries(wasmlib PUBLIC wamr::wamr)
