This is an automated email from the ASF dual-hosted git repository. cmcfarlen pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit f63c1a23cc804a89992127d279ccd67dcac30195 Author: Brian Neradt <[email protected]> AuthorDate: Mon Jul 15 13:50:58 2024 -0500 setup_server_read_response_header: remove assertion (#11548) This addresses an intermittent assertion failure associated with Expect: 100-Continue via the h2origin.test.py autest introduced via #11536. Since the 100 Continue is followed immediately by 200 OK, it is possible that both are processed at once if the Expect: 100-Continue request has no body. In these cases, the assertion will fail because state_read_server_response_header will have processed the entire response. Since that is now possible, we might as well just remove the assertion. In theory, it can be kept for the case when there is no response bytes available to read, but in those situations the assertion isn't really doing anything because there will be no complicated logic from state_read_server_response_header and we set the server_entry->vc earlier in the function. (cherry picked from commit 05a58d10df279182b8ce5fc22129e31fa62d80bb) --- src/proxy/http/HttpSM.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/proxy/http/HttpSM.cc b/src/proxy/http/HttpSM.cc index a3cd0eb644..5fd1e7fd72 100644 --- a/src/proxy/http/HttpSM.cc +++ b/src/proxy/http/HttpSM.cc @@ -6668,7 +6668,6 @@ HttpSM::setup_server_read_response_header() if (server_txn->get_remote_reader()->read_avail() > 0) { state_read_server_response_header((server_entry->eos) ? VC_EVENT_EOS : VC_EVENT_READ_READY, server_entry->read_vio); } - ink_assert(server_entry->vc != nullptr); } HttpTunnelProducer *
