This is an automated email from the ASF dual-hosted git repository. bcall pushed a commit to branch cachekey_pcre2 in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 393bcc29baf26df483730448e2f6fc0f88b5a094 Author: Bryan Call <[email protected]> AuthorDate: Thu Nov 6 11:35:53 2025 -0800 Remove virtual from Pattern destructor and use default Address @bneradt's review comment: Pattern class has no inheritance, so the destructor doesn't need to be virtual. Changed to = default and removed the empty implementation from the .cc file. --- plugins/cachekey/pattern.cc | 5 ----- plugins/cachekey/pattern.h | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/plugins/cachekey/pattern.cc b/plugins/cachekey/pattern.cc index efdae618ac..e871e15f03 100644 --- a/plugins/cachekey/pattern.cc +++ b/plugins/cachekey/pattern.cc @@ -130,11 +130,6 @@ Pattern::empty() const return _pattern.empty() || _re.empty(); } -/** - * @brief Destructor. - */ -Pattern::~Pattern() {} - /** * @brief Capture or capture-and-replace depending on whether a replacement string is specified. * @see replace() diff --git a/plugins/cachekey/pattern.h b/plugins/cachekey/pattern.h index afb2b29eb1..e3f441d27a 100644 --- a/plugins/cachekey/pattern.h +++ b/plugins/cachekey/pattern.h @@ -37,7 +37,7 @@ public: static const int TOKENCOUNT = 10; /**< @brief Capturing groups $0..$9 */ Pattern(); - virtual ~Pattern(); + ~Pattern() = default; bool init(const String &pattern, const String &replacement, bool replace); bool init(const String &config);
