This is an automated email from the ASF dual-hosted git repository.
bneradt pushed a commit to branch 9.2.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/9.2.x by this push:
new c1c5b0118f Fix hanging SDK_API_HttpParentProxySet regression tests
(#12721) (#12726)
c1c5b0118f is described below
commit c1c5b0118f295a5161ac71054c39717f184ae771
Author: Brian Neradt <[email protected]>
AuthorDate: Wed Dec 3 17:21:43 2025 -0600
Fix hanging SDK_API_HttpParentProxySet regression tests (#12721) (#12726)
Remove the check for parent_routing_enabled() in the
SDK_API_HttpParentProxySet
regression tests. This check has been broken since 2019 when commit
6d1535b193a4
removed the proxy.config.http.parent_proxy_routing_enable configuration
variable
as redundant.
The ParentEnable field in ParentSelectionPolicy is no longer set by any code
(defaults to 0) and is not checked anywhere except this test. The test was
waiting indefinitely for parent_routing_enabled() to return true, which
would
never happen in a default configuration.
The test uses TSHttpTxnParentProxySet() to dynamically set a parent proxy
via
the API, which works regardless of whether parent routing is configured in
parent.config. The check was unnecessary and caused the test to hang at
regression level 3 (-R 3).
This allows the SDK_API_HttpParentProxySet_Success and _Fail tests to
complete
successfully.
(cherry picked from commit 3f2b5c873c3a6ce7486718ffec9650fa3d08a2e6)
Co-authored-by: Bryan Call <[email protected]>
---
src/traffic_server/InkAPITest.cc | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/traffic_server/InkAPITest.cc b/src/traffic_server/InkAPITest.cc
index 0e0cac586b..808e922c02 100644
--- a/src/traffic_server/InkAPITest.cc
+++ b/src/traffic_server/InkAPITest.cc
@@ -7321,13 +7321,10 @@ parent_proxy_handler(TSCont contp, TSEvent event, void
*edata)
break;
}
- if (!ptest->parent_routing_enabled()) {
- rprintf(ptest->regtest, "waiting for configuration\n");
- TSContScheduleOnPool(contp, 100, TS_THREAD_POOL_NET);
- break;
- }
+ // This test uses TSHttpTxnParentProxySet() to dynamically set the
parent proxy via
+ // the API, which works regardless of parent.config configuration.
- // Now that the configuration is applied, it is safe to create a request.
+ // Now it is safe to create a request.
// HTTP_REQUEST_FORMAT11 is a hostname with a no-cache response, so
// we will need to set the parent to the synserver to get a
// response.
