This is an automated email from the ASF dual-hosted git repository. bneradt pushed a commit to branch revert-12783-address_regression_test_crashlog in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 53255d68479dce25857f5c254063f7c58425badf Author: Brian Neradt <[email protected]> AuthorDate: Thu Jan 8 10:34:43 2026 -0600 Revert "Fix false crash logs with regression tests (#12783)" This reverts commit dd3455cffa13c3c802ec4bf711f6e2f4ad5b4f10. --- src/traffic_crashlog/traffic_crashlog.cc | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/src/traffic_crashlog/traffic_crashlog.cc b/src/traffic_crashlog/traffic_crashlog.cc index 68c94acb6f..9354c5f838 100644 --- a/src/traffic_crashlog/traffic_crashlog.cc +++ b/src/traffic_crashlog/traffic_crashlog.cc @@ -32,7 +32,6 @@ #include "tscore/BaseLogFile.h" #include "tscore/runroot.h" #include "iocore/eventsystem/RecProcess.h" -#include <poll.h> #include <unistd.h> static int syslog_mode = false; @@ -172,25 +171,6 @@ main(int /* argc ATS_UNUSED */, const char **argv) return 0; } - // In wait mode, we need to verify this is a real crash by checking if crash_logger_invoke - // sent us signal info via the pipe. If traffic_server just exited normally, the pipe will be - // closed with no data, and we should exit without logging a false "crash". - if (wait_mode) { - // Use poll to check if there's data available on stdin without blocking indefinitely. - struct pollfd pfd; - pfd.fd = STDIN_FILENO; - pfd.events = POLLIN; - - // Wait briefly for data. If crash_logger_invoke was called, data should already be there. - int poll_result = poll(&pfd, 1, 100); // 100ms timeout - - // POLLHUP means the write end of the pipe was closed - normal exit, not crash. - // No data or error also means no crash occurred. - if (poll_result <= 0 || (pfd.revents & POLLHUP) || !(pfd.revents & POLLIN)) { - return 0; - } - } - runroot_handler(argv); Layout::create(); RecProcessInit(nullptr /* diags */);
