changeset 87f44ee526d0 in trytond:5.0 details: https://hg.tryton.org/trytond?cmd=changeset;node=87f44ee526d0 description: Always commit deleted/inactivated XML record
The transaction must be committed on each iteration in case the next one fails and the transaction is roll-backed. issue7884 review66471002 (grafted from d1dca83b5330d471486a26f40d1f0ab7f6930aae) diffstat: trytond/convert.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (19 lines): diff -r dfa98ac184c1 -r 87f44ee526d0 trytond/convert.py --- a/trytond/convert.py Fri Nov 23 16:01:36 2018 +0100 +++ b/trytond/convert.py Wed Nov 28 10:02:50 2018 +0100 @@ -800,7 +800,6 @@ logger.warning( 'Could not delete id %d of model %s because model no ' 'longer exists.', db_id, model) - transaction.commit() except Exception: transaction.rollback() logger.error( @@ -820,6 +819,7 @@ logger.error( 'Could not inactivate id: %d of model %s\n', db_id, model, exc_info=True) + transaction.commit() # Clean model_data: if mdata_delete: