(tsfile) branch develop updated: fix(tsfile): propagate IOException on writer close instead of swallowing it (#899)

[jackietien]

This is an automated email from the ASF dual-hosted git repository.

JackieTien97 pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/tsfile.git


The following commit(s) were added to refs/heads/develop by this push:
     new 246554207 fix(tsfile): propagate IOException on writer close instead 
of swallowing it (#899)
246554207 is described below

commit 24655420704749cbb4289d1aca8a007127a6fc42
Author: shuwenwei <55970239+shuwen...@users.noreply.github.com>
AuthorDate: Thu Aug 6 16:33:03 2026 +0800

    fix(tsfile): propagate IOException on writer close instead of swallowing it 
(#899)
---
 .../main/resources/org/apache/tsfile/i18n/messages.properties  |  3 ---
 .../resources/org/apache/tsfile/i18n/messages_zh.properties    |  3 ---
 .../apache/tsfile/write/v4/AbstractTableModelTsFileWriter.java | 10 +++-------
 .../main/java/org/apache/tsfile/write/v4/ITsFileWriter.java    |  2 +-
 4 files changed, 4 insertions(+), 14 deletions(-)

diff --git 
a/java/common/src/main/resources/org/apache/tsfile/i18n/messages.properties 
b/java/common/src/main/resources/org/apache/tsfile/i18n/messages.properties
index 9f6f35857..ffea7c054 100644
--- a/java/common/src/main/resources/org/apache/tsfile/i18n/messages.properties
+++ b/java/common/src/main/resources/org/apache/tsfile/i18n/messages.properties
@@ -202,9 +202,6 @@ log.write.flush_chunk_groups = start to flush chunk groups, 
memory space occupy:
 # TsFileWriter / AbstractTableModelTsFileWriter — close file (2 files, 1 key)
 log.write.close_file = start close file
 
-# AbstractTableModelTsFileWriter — close file exception (1 site)
-log.write.close_file_exception = Meet exception when close file writer.
-
 # TsFileWriter / AbstractTableModelTsFileWriter — page size vs chunk group 
size warn (2 files, 1 key)
 log.write.page_size_warn = TsFile's page size {} is greater than chunk group 
size {}, please enlarge the chunk group size or decrease page size.
 
diff --git 
a/java/common/src/main/resources/org/apache/tsfile/i18n/messages_zh.properties 
b/java/common/src/main/resources/org/apache/tsfile/i18n/messages_zh.properties
index 17c341af2..453977c76 100644
--- 
a/java/common/src/main/resources/org/apache/tsfile/i18n/messages_zh.properties
+++ 
b/java/common/src/main/resources/org/apache/tsfile/i18n/messages_zh.properties
@@ -202,9 +202,6 @@ log.write.flush_chunk_groups = 开始刷新 chunk groups，占用内存空间: {
 # TsFileWriter / AbstractTableModelTsFileWriter — close file (2 files, 1 key)
 log.write.close_file = 开始关闭文件
 
-# AbstractTableModelTsFileWriter — close file exception (1 site)
-log.write.close_file_exception = 关闭文件 writer 时发生异常。
-
 # TsFileWriter / AbstractTableModelTsFileWriter — page size vs chunk group 
size warn (2 files, 1 key)
 log.write.page_size_warn = TsFile 的 page size {} 大于 chunk group size {}，请增大 
chunk group size 或减小 page size。
 
diff --git 
a/java/tsfile/src/main/java/org/apache/tsfile/write/v4/AbstractTableModelTsFileWriter.java
 
b/java/tsfile/src/main/java/org/apache/tsfile/write/v4/AbstractTableModelTsFileWriter.java
index 108de0051..cf7e3b651 100644
--- 
a/java/tsfile/src/main/java/org/apache/tsfile/write/v4/AbstractTableModelTsFileWriter.java
+++ 
b/java/tsfile/src/main/java/org/apache/tsfile/write/v4/AbstractTableModelTsFileWriter.java
@@ -271,13 +271,9 @@ abstract class AbstractTableModelTsFileWriter implements 
ITsFileWriter {
    */
   @Override
   @TsFileApi
-  public void close() {
+  public void close() throws IOException {
     LOG.info(Messages.get("log.write.close_file"));
-    try {
-      flush();
-      fileWriter.endFile();
-    } catch (IOException e) {
-      LOG.warn(Messages.get("log.write.close_file_exception"), e);
-    }
+    flush();
+    fileWriter.endFile();
   }
 }
diff --git 
a/java/tsfile/src/main/java/org/apache/tsfile/write/v4/ITsFileWriter.java 
b/java/tsfile/src/main/java/org/apache/tsfile/write/v4/ITsFileWriter.java
index d20c432c5..809d1e5cf 100644
--- a/java/tsfile/src/main/java/org/apache/tsfile/write/v4/ITsFileWriter.java
+++ b/java/tsfile/src/main/java/org/apache/tsfile/write/v4/ITsFileWriter.java
@@ -32,7 +32,7 @@ public interface ITsFileWriter extends AutoCloseable {
   void write(Tablet tablet) throws IOException, WriteProcessException;
 
   @TsFileApi
-  void close();
+  void close() throws IOException;
 
   @TsFileApi
   void write(TSRecord record) throws IOException, WriteProcessException;