hystericalhell commented on a change in pull request #142:
URL: https://github.com/apache/incubator-tubemq/pull/142#discussion_r443505255
##########
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/metadata/TopicMetadata.java
##########
@@ -95,57 +97,63 @@ public TopicMetadata(final BrokerDefMetadata
brokerDefMetadata, String topicMeta
this.unflushInterval = Integer.parseInt(topicConfInfoArr[5]);
}
if (TStringUtils.isBlank(topicConfInfoArr[6])) {
- this.deleteWhen = brokerDefMetadata.getDeleteWhen();
+ this.unflushSizeThreshold =
brokerDefMetadata.getUnflushSizeThreshold();
Review comment:
Easier for read, since it would be hard to realize the sequence if it
evaluates topicConfInfoArr[7] and then a topicConfInfoArr[14] follows, people
would feel weird about what's happening to 8-13 and guess whether they are
no-in-use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
