gosonzhang commented on a change in pull request #342:
URL: https://github.com/apache/incubator-tubemq/pull/342#discussion_r535863095
##########
File path:
tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tubemq/TubemqTableSourceSinkFactory.java
##########
@@ -69,6 +69,10 @@
private static final String SPLIT_COMMA = ",";
+ public static TubemqTableSourceSinkFactory getInstance() {
Review comment:
Why not directly change the class object to public if you want to use
the singleton mode?
If it is not used as a singleton mode, I feel that the modification plan
mentioned on the issue will be better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
