yuanboliu commented on a change in pull request #383:
URL: https://github.com/apache/incubator-tubemq/pull/383#discussion_r553703329
##########
File path:
tubemq-manager/src/main/java/org/apache/tubemq/manager/service/NodeService.java
##########
@@ -449,33 +441,56 @@ public TubeMQResult cloneTopicToBrokers(CloneTopicReq
req, NodeEntry master) thr
}
- public TubeMQResult cloneOffsetToOtherGroups(CloneOffsetReq req, NodeEntry
master)
- throws Exception {
- // 1. query the corresponding brokers having given topic
- TubeHttpTopicInfoList topicInfoList = requestTopicConfigInfo(master,
req.getTopicName());
- TubeMQResult result = new TubeMQResult();
+ private TubeMQResult addBrokersToCluster(AddBrokersReq req, NodeEntry
masterEntry) {
Review comment:
reuse baseRequestMaster method.
##########
File path:
tubemq-manager/src/main/java/org/apache/tubemq/manager/service/TopicService.java
##########
@@ -0,0 +1,249 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tubemq.manager.service;
+
+
+import static
org.apache.tubemq.manager.service.TubeMQHttpConst.QUERY_GROUP_DETAIL_INFO;
+import static org.apache.tubemq.manager.service.TubeMQHttpConst.SCHEMA;
+import static
org.apache.tubemq.manager.service.TubeMQHttpConst.TOPIC_CONFIG_INFO;
+import static
org.apache.tubemq.manager.utils.ConvertUtils.convertReqToQueryStr;
+import static
org.apache.tubemq.manager.utils.ConvertUtils.convertToRebalanceConsumerReq;
+import static org.apache.tubemq.manager.service.MasterService.SUCCESS_CODE;
+import static
org.apache.tubemq.manager.service.MasterService.TUBE_REQUEST_PATH;
+import static org.apache.tubemq.manager.service.MasterService.requestMaster;
+
+import com.google.gson.Gson;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.Objects;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.tubemq.manager.controller.TubeMQResult;
+import org.apache.tubemq.manager.controller.group.request.DeleteOffsetReq;
+import org.apache.tubemq.manager.controller.node.request.CloneOffsetReq;
+import org.apache.tubemq.manager.controller.topic.request.BatchAddGroupAuthReq;
+import org.apache.tubemq.manager.controller.topic.request.DeleteGroupReq;
+import org.apache.tubemq.manager.controller.topic.request.RebalanceConsumerReq;
+import org.apache.tubemq.manager.controller.topic.request.RebalanceGroupReq;
+import org.apache.tubemq.manager.entry.NodeEntry;
+import org.apache.tubemq.manager.repository.NodeRepository;
+import org.apache.tubemq.manager.service.tube.CleanOffsetResult;
+import org.apache.tubemq.manager.service.tube.RebalanceGroupResult;
+import org.apache.tubemq.manager.service.tube.TubeHttpGroupDetailInfo;
+import org.apache.tubemq.manager.service.tube.TubeHttpTopicInfoList;
+import
org.apache.tubemq.manager.service.tube.TubeHttpTopicInfoList.TopicInfoList.TopicInfo;
+import org.apache.tubemq.manager.utils.ConvertUtils;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.stereotype.Component;
+
+/**
+ * node service to query broker/master/standby status of tube cluster.
+ */
+@Slf4j
+@Component
+public class TopicService {
+
+ @Autowired
+ private NodeRepository nodeRepository;
+
+ private final CloseableHttpClient httpclient = HttpClients.createDefault();
+ private final Gson gson = new Gson();
+
+ @Value("${manager.broker.webPort:8081}")
+ private int brokerWebPort;
+
+
+ public TubeMQResult addConsumer(
+ BatchAddGroupAuthReq req) {
+ NodeEntry nodeEntry =
+
nodeRepository.findNodeEntryByClusterIdIsAndMasterIsTrue(req.getClusterId());
+ if (nodeEntry == null) {
+ return TubeMQResult.getErrorResult("no such cluster");
+ }
+ String url = SCHEMA + nodeEntry.getIp() + ":" + nodeEntry.getWebPort()
Review comment:
reuse baseRequestMaster
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
