yuanboliu commented on a change in pull request #405:
URL: https://github.com/apache/incubator-tubemq/pull/405#discussion_r561627969
##########
File path:
tubemq-manager/src/main/java/org/apache/tubemq/manager/entry/NodeEntry.java
##########
@@ -32,8 +32,8 @@
@Data
public class NodeEntry {
@Id
- @GeneratedValue(strategy= GenerationType.AUTO)
- private long brokerId;
+ @GeneratedValue(strategy= GenerationType.IDENTITY)
Review comment:
what if clusters have conflicted broker ids.
for example A cluster has broker which id is num_a, meanwhile B cluster also
has broker with the same id.
It seems better that we need create a colume called brokerId without any
annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
