gosonzhang commented on a change in pull request #453:
URL: https://github.com/apache/incubator-tubemq/pull/453#discussion_r609504788
##########
File path: tubemq-client-twins/tubemq-client-cpp/src/tubemq_config.cc
##########
@@ -32,6 +32,112 @@ using std::set;
using std::stringstream;
using std::vector;
+
+
+TubeMQServiceConfig::TubeMQServiceConfig() {
Review comment:
I think it’s better to keep the current initialization mode: if the
initialization is done in the .h file, the internal const_config.h file will be
exposed to the outside, which will make the API definitions of the user contact
not concise enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
