Author: painter Date: Tue Nov 6 22:05:47 2018 New Revision: 1845969 URL: http://svn.apache.org/viewvc?rev=1845969&view=rev Log: Change of setName() null test introduced a failure in org.apache.turbine.pipeline.DefaultLoginValveTest, reverting change
Modified: turbine/fulcrum/trunk/security/api/src/java/org/apache/fulcrum/security/entity/impl/SecurityEntityImpl.java Modified: turbine/fulcrum/trunk/security/api/src/java/org/apache/fulcrum/security/entity/impl/SecurityEntityImpl.java URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/security/api/src/java/org/apache/fulcrum/security/entity/impl/SecurityEntityImpl.java?rev=1845969&r1=1845968&r2=1845969&view=diff ============================================================================== --- turbine/fulcrum/trunk/security/api/src/java/org/apache/fulcrum/security/entity/impl/SecurityEntityImpl.java (original) +++ turbine/fulcrum/trunk/security/api/src/java/org/apache/fulcrum/security/entity/impl/SecurityEntityImpl.java Tue Nov 6 22:05:47 2018 @@ -1,6 +1,5 @@ package org.apache.fulcrum.security.entity.impl; -import org.apache.commons.lang3.StringUtils; /* * Licensed to the Apache Software Foundation (ASF) under one @@ -34,7 +33,12 @@ import org.apache.fulcrum.security.entit */ public class SecurityEntityImpl implements SecurityEntity { - private String name; + /** + * Serial id + */ + private static final long serialVersionUID = 6949229336753158100L; + + private String name; private Object id; @@ -70,10 +74,12 @@ public class SecurityEntityImpl implemen */ public void setName(String name) throws IllegalArgumentException { - if (StringUtils.isEmpty(name)) + if ( name == null ) + { throw new IllegalArgumentException("Must provide a valid name for all SecurityEntities."); - else + } else { this.name = name.toLowerCase(); + } } @Override