Author: painter
Date: Thu Dec 13 21:04:26 2018
New Revision: 1848895
URL: http://svn.apache.org/viewvc?rev=1848895&view=rev
Log:
JavaDoc updates, rename test case testRepositoryExists() to more descriptive
testAlternateCaseFoldings() in ParameterParserTest, updated changes to reflect
new parent POM etc
Modified:
turbine/fulcrum/trunk/parser/src/changes/changes.xml
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/ParserService.java
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/ParameterParserTest.java
Modified: turbine/fulcrum/trunk/parser/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/changes/changes.xml?rev=1848895&r1=1848894&r2=1848895&view=diff
==============================================================================
--- turbine/fulcrum/trunk/parser/src/changes/changes.xml (original)
+++ turbine/fulcrum/trunk/parser/src/changes/changes.xml Thu Dec 13 21:04:26
2018
@@ -23,6 +23,12 @@
<body>
<release version="2.0.0" date="in SVN">
+ <action dev="painter" type="update">
+ Update dependency commons-lang3 to 3.8.1
+ </action>
+ <action dev="painter" type="update">
+ Derive from Turbine parent POM 5
+ </action>
<action dev="tv" type="remove">
INCOMAPTIBLE: Remove dependency on fulcrum-upload.
All FileItems are now Parts.
@@ -33,9 +39,6 @@
<action dev="tv" type="update">
Require Java-8
</action>
- <action dev="tv" type="update">
- Derive from Turbine parent POM 4
- </action>
</release>
<release version="1.0.3" date="2013-10-03">
<action dev="tv" type="update">
Modified:
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/ParserService.java
URL:
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/ParserService.java?rev=1848895&r1=1848894&r2=1848895&view=diff
==============================================================================
---
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/ParserService.java
(original)
+++
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/ParserService.java
Thu Dec 13 21:04:26 2018
@@ -128,6 +128,7 @@ public interface ParserService
* Get a {@link ValueParser} instance from the service. Use the
* default implementation.
*
+ * @param <P> The ValueParser we are using
* @param ppClass parameter parser class
* @return An object that implements ValueParser
* @throws InstantiationException if the instance could not be created
Modified:
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java
URL:
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java?rev=1848895&r1=1848894&r2=1848895&view=diff
==============================================================================
---
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java
(original)
+++
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java
Thu Dec 13 21:04:26 2018
@@ -48,7 +48,7 @@ public class BaseValueParserTest extends
/**
* Performs any initialization that must happen before each test is run.
- * @throws Exception
+ * @throws Exception if parser service not found
*/
@BeforeEach
public void setUp() throws Exception
@@ -122,6 +122,7 @@ public class BaseValueParserTest extends
result = parser.getByte("unparsable");
assertEquals(result, 0);
}
+
@Test
public void testGetByteObject()
{
@@ -143,6 +144,7 @@ public class BaseValueParserTest extends
result = parser.getByteObject("unparsable");
assertNull(result);
}
+
@Test
public void testGetInt()
{
Modified:
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/ParameterParserTest.java
URL:
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/ParameterParserTest.java?rev=1848895&r1=1848894&r2=1848895&view=diff
==============================================================================
---
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/ParameterParserTest.java
(original)
+++
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/ParameterParserTest.java
Thu Dec 13 21:04:26 2018
@@ -129,6 +129,11 @@ public class ParameterParserTest extends
}
}
+ /**
+ * Simple test to verify the current configuration of URL Case Folding
+ *
+ * @throws Exception generic exception
+ */
@Test
public void testConfiguredUrlCaseFolding() throws Exception
{
@@ -136,13 +141,14 @@ public class ParameterParserTest extends
}
/**
- * Simple test to verify that URL Case Folding works properly
+ * Simple test to verify that variations on URL Case Folding work properly
*
- * @throws Exception
+ * @throws Exception if the parameter parser is not found
*/
@Test
- public void testRepositoryExists() throws Exception
+ public void testAlternateCaseFoldings() throws Exception
{
+
assertEquals(parameterParser.convertAndTrim(" TRIMMED_and_Not_Modified
", URLCaseFolding.NONE),"TRIMMED_and_Not_Modified");
assertEquals(parameterParser.convertAndTrim(" TRIMMED_and_Lower_Case
", URLCaseFolding.LOWER),"trimmed_and_lower_case");
assertEquals(parameterParser.convertAndTrim(" TRIMMED_and_Upper_Case
", URLCaseFolding.UPPER),"TRIMMED_AND_UPPER_CASE");
@@ -153,7 +159,7 @@ public class ParameterParserTest extends
* The suggested problem was that pp.keySet() returns both Keys, but
pp.getStrings("key")
* only checks for keys which are not Parts.
*
- * @throws Exception
+ * @throws Exception generic exception
*/
@Test
public void testAddPathInfo() throws Exception
@@ -194,7 +200,7 @@ public class ParameterParserTest extends
/**
* This Test method checks the DefaultParameterParser which filename
convenience mapping from Part.
*
- * @throws Exception
+ * @throws Exception generic exception
*/
@Test
public void testFilename4Path() throws Exception
