svn commit: r1851537 - in /turbine/fulcrum/trunk/parser: ./ src/java/org/apache/fulcrum/parser/ src/java/org/apache/fulcrum/parser/pool/ src/test/org/apache/fulcrum/parser/ xdocs/

[painter]

Author: painter
Date: Thu Jan 17 15:22:22 2019
New Revision: 1851537

URL: http://svn.apache.org/viewvc?rev=1851537&view=rev
Log:
Update site documentation, add unit tests for pool and factory methods

Modified:
    turbine/fulcrum/trunk/parser/pom.xml
    
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java
    
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/DefaultCookieParser.java
    
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/pool/CookieParserFactory.java
    
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java
    turbine/fulcrum/trunk/parser/xdocs/index.xml

Modified: turbine/fulcrum/trunk/parser/pom.xml
URL: 
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/pom.xml?rev=1851537&r1=1851536&r2=1851537&view=diff
==============================================================================
--- turbine/fulcrum/trunk/parser/pom.xml (original)
+++ turbine/fulcrum/trunk/parser/pom.xml Thu Jan 17 15:22:22 2019
@@ -70,6 +70,15 @@
         <role>Java Developer</role>
       </roles>
     </developer>
+    <developer>
+      <name>Jeffery Painter</name>
+      <id>painter</id>
+      <email>pain...@apache.org</email>
+      <organization />
+      <roles>
+        <role>Java Developer</role>
+      </roles>
+    </developer>
   </developers>
 
   <dependencies>

Modified: 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java
URL: 
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java?rev=1851537&r1=1851536&r2=1851537&view=diff
==============================================================================
--- 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java
 (original)
+++ 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/BaseValueParser.java
 Thu Jan 17 15:22:22 2019
@@ -1682,8 +1682,10 @@ public class BaseValueParser
 
        public boolean isValid() 
        {
-               if ( this.characterEncoding != null && this.locale != null )
-                       return true;
-               return false;
+       if ( this.parameters.size() == 0 )
+       {
+               return true;
+       }
+       return false;
        }
 }

Modified: 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/DefaultCookieParser.java
URL: 
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/DefaultCookieParser.java?rev=1851537&r1=1851536&r2=1851537&view=diff
==============================================================================
--- 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/DefaultCookieParser.java
 (original)
+++ 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/DefaultCookieParser.java
 Thu Jan 17 15:22:22 2019
@@ -169,7 +169,7 @@ public class DefaultCookieParser
      */
     public boolean isValid() 
     {
-       if ( this.request == null )
+       if ( this.parameters.size() == 0 )
        {
                return true;
        }

Modified: 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/pool/CookieParserFactory.java
URL: 
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/pool/CookieParserFactory.java?rev=1851537&r1=1851536&r2=1851537&view=diff
==============================================================================
--- 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/pool/CookieParserFactory.java
 (original)
+++ 
turbine/fulcrum/trunk/parser/src/java/org/apache/fulcrum/parser/pool/CookieParserFactory.java
 Thu Jan 17 15:22:22 2019
@@ -22,12 +22,11 @@ package org.apache.fulcrum.parser.pool;
 import org.apache.commons.pool2.BasePooledObjectFactory;
 import org.apache.commons.pool2.PooledObject;
 import org.apache.commons.pool2.impl.DefaultPooledObject;
-import org.apache.fulcrum.parser.CookieParser;
 import org.apache.fulcrum.parser.DefaultCookieParser;
 
 
 /**
- * Factory to create {@link org.apache.fulcrum.parser.CookieParser} objects
+ * Factory to create {@link org.apache.fulcrum.parser.DefaultCookieParser} 
objects
  *
  * @author <a href="mailto:pain...@apache.org";>Jeffery Painter</a>
  * @version $Id: CookieParserFactory.java 1851080 2019-01-16 12:07:00Z painter 
$

Modified: 
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java
URL: 
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java?rev=1851537&r1=1851536&r2=1851537&view=diff
==============================================================================
--- 
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java
 (original)
+++ 
turbine/fulcrum/trunk/parser/src/test/org/apache/fulcrum/parser/BaseValueParserTest.java
 Thu Jan 17 15:22:22 2019
@@ -74,6 +74,7 @@ public class BaseValueParserTest extends
         parserService.putParser(parser);
         this.release(parserService);
     }
+    
     @Test
     public void testDate()
     {

Modified: turbine/fulcrum/trunk/parser/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/turbine/fulcrum/trunk/parser/xdocs/index.xml?rev=1851537&r1=1851536&r2=1851537&view=diff
==============================================================================
--- turbine/fulcrum/trunk/parser/xdocs/index.xml (original)
+++ turbine/fulcrum/trunk/parser/xdocs/index.xml Thu Jan 17 15:22:22 2019
@@ -42,9 +42,6 @@
       The component uses the following services from the Fulcrum Repository
       <ul>
         <li>
-          <a href="http://turbine.apache.org/fulcrum/fulcrum-pool/";>Fulcrum 
Pool Service</a>
-        </li>
-        <li>
           <a href="http://turbine.apache.org/fulcrum/fulcrum-upload/";>Fulcrum 
Upload Service</a>
           (optional)
         </li>