This is an automated email from the ASF dual-hosted git repository.

gk pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/turbine-fulcrum-testcontainer.git


The following commit(s) were added to refs/heads/master by this push:
     new b7abd86  Fix dependencies, upate to SNAPSHOT, remove provided for 
jakarta servlet as it is required for BaseUnit4 /5 exported base test classes
b7abd86 is described below

commit b7abd86b8770612a892f0c60040ffa6613d49343
Author: gemkall <[email protected]>
AuthorDate: Thu Jul 18 09:47:16 2024 +0200

    Fix dependencies, upate to SNAPSHOT, remove provided for jakarta servlet as 
it is required for BaseUnit4 /5 exported base test classes
---
 pom.xml | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/pom.xml b/pom.xml
index b7f9323..2d1519f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -47,7 +47,8 @@
     </developers>
 
     <dependencies>
-    <!-- we still need this dependency to compile -->
+    <!-- testcontainer will be set in scope test  -->
+    <!-- do not set test scope to allow for running surefire test with junit 4 
 -->
     <dependency>
         <groupId>junit</groupId>
         <artifactId>junit</artifactId>
@@ -57,30 +58,27 @@
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter</artifactId>
       <version>${junit.jupiter.version}</version>
-      <!-- do not set test scope to allow for runngi surefire test with junit 
5  -->
-      <!--scope>test</scope -->
+      <!-- testcontainer will be set in scope test, but required deps should 
be not in test scope to allow for running surefire test with junit 5  -->
     </dependency>
     <!-- use Junit 4 within Junit 5 -->
      <dependency>
         <groupId>org.junit.vintage</groupId>
         <artifactId>junit-vintage-engine</artifactId>
          <version>${junit.jupiter.version}</version>
-         <!-- do not set test scope to allow for runngi surefire test with 
junit 4  -->
-        <!--scope>test</scope-->
     </dependency>
 
     <!-- Needed if testing with YAAFI -->
     <dependency>
         <groupId>org.apache.fulcrum</groupId>
         <artifactId>fulcrum-yaafi</artifactId>
-        <version>2.0.0</version>
+        <version>2.0.1-SNAPSHOT</version>
         <optional>true</optional>
     </dependency>
+    <!-- required for testcontainer and not test scope, we have to define 
version here -->
     <dependency>
         <groupId>jakarta.servlet</groupId>
         <artifactId>jakarta.servlet-api</artifactId>
         <version>6.1.0</version>
-        <scope>provided</scope>
     </dependency>
     <dependency>
         <groupId>org.mockito</groupId>
@@ -163,8 +161,7 @@
     <properties>
         <turbine.site.path>turbine-fulcrum-testcontainer</turbine.site.path>
         
<turbine.scmPubCheckoutDirectory>${turbine.site.cache}/fulcrum/testcontainer</turbine.scmPubCheckoutDirectory>
-        <junit.jupiter.version>5.10.2</junit.jupiter.version>
-        <junit.platform>1.9.3</junit.platform>
+        <junit.jupiter.version>5.11.0-M2</junit.jupiter.version>
     </properties>
 
 </project>

Reply via email to