svn commit: r767236 - in /tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl: CompositeReferenceImpl.java ReferenceImpl.java

[rfeng]

Author: rfeng
Date: Tue Apr 21 17:28:15 2009
New Revision: 767236

URL: http://svn.apache.org/viewvc?rev=767236&view=rev
Log:
Make sure the lists are cloned too (TUSCANY-2982)

Modified:
    
tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CompositeReferenceImpl.java
    
tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ReferenceImpl.java

Modified: 
tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CompositeReferenceImpl.java
URL: 
http://svn.apache.org/viewvc/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CompositeReferenceImpl.java?rev=767236&r1=767235&r2=767236&view=diff
==============================================================================
--- 
tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CompositeReferenceImpl.java
 (original)
+++ 
tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CompositeReferenceImpl.java
 Tue Apr 21 17:28:15 2009
@@ -43,7 +43,10 @@
     
     @Override
     public Object clone() throws CloneNotSupportedException {
-        return super.clone();
+        CompositeReferenceImpl copy = (CompositeReferenceImpl)super.clone();
+        copy.promotedComponents = new ArrayList<Component>(promotedComponents);
+        copy.promotedReferences = new 
ArrayList<ComponentReference>(promotedReferences);
+        return copy;
     }
 
     public List<ComponentReference> getPromotedReferences() {

Modified: 
tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ReferenceImpl.java
URL: 
http://svn.apache.org/viewvc/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ReferenceImpl.java?rev=767236&r1=767235&r2=767236&view=diff
==============================================================================
--- 
tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ReferenceImpl.java
 (original)
+++ 
tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ReferenceImpl.java
 Tue Apr 21 17:28:15 2009
@@ -51,12 +51,9 @@
     @Override
     public Object clone() throws CloneNotSupportedException {
         ReferenceImpl clone = (ReferenceImpl)super.clone();
-        clone.bindings = new ArrayList<Binding>();
-        clone.bindings.addAll(getBindings());
-        clone.targets = new ArrayList<ComponentService>();
-        clone.targets.addAll(getTargets());
-        clone.endpointReferences = new ArrayList<EndpointReference2>();
-        clone.endpointReferences.addAll(getEndpointReferences());
+        clone.bindings = new ArrayList<Binding>(bindings);
+        clone.targets = new ArrayList<ComponentService>(targets);
+        clone.endpointReferences = new 
ArrayList<EndpointReference2>(endpointReferences);
         return clone;
     }