Author: nash
Date: Fri Jun  4 20:39:35 2010
New Revision: 951561

URL: http://svn.apache.org/viewvc?rev=951561&view=rev
Log:
Fix NullPointerException caused by missing tests for null callback interface 
(TUSCANY-3588)

Modified:
    
tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentDocumentProcessor.java
    
tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentTypeDocumentProcessor.java

Modified: 
tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentDocumentProcessor.java
URL: 
http://svn.apache.org/viewvc/tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentDocumentProcessor.java?rev=951561&r1=951560&r2=951561&view=diff
==============================================================================
--- 
tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentDocumentProcessor.java
 (original)
+++ 
tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentDocumentProcessor.java
 Fri Jun  4 20:39:35 2010
@@ -85,11 +85,13 @@ public class ComponentDocumentProcessor 
 
                         }
 
-                        for (Operation operation : 
interfaceContract.getCallbackInterface().getOperations()) {
+                        if (interfaceContract.getCallbackInterface() != null) {
+                            for (Operation operation : 
interfaceContract.getCallbackInterface().getOperations()) {
 
-                            serviceDoc.add(new 
Field(SearchFields.SERVICE_INTERFACE_CALLBACK_FIELD,
-                                                     operation.getName(), 
Field.Store.YES, Field.Index.ANALYZED));
+                                serviceDoc.add(new 
Field(SearchFields.SERVICE_INTERFACE_CALLBACK_FIELD,
+                                                         operation.getName(), 
Field.Store.YES, Field.Index.ANALYZED));
 
+                            }
                         }
 
                     }
@@ -115,12 +117,14 @@ public class ComponentDocumentProcessor 
 
                         }
 
-                        for (Operation operation : 
interfaceContract.getCallbackInterface().getOperations()) {
+                        if (interfaceContract.getCallbackInterface() != null) {
+                            for (Operation operation : 
interfaceContract.getCallbackInterface().getOperations()) {
 
-                            referenceDoc.add(new 
Field(SearchFields.REFERENCE_INTERFACE_CALLBACK_FIELD, operation
-                                .getName(), Field.Store.YES, 
Field.Index.ANALYZED));
+                                referenceDoc.add(new 
Field(SearchFields.REFERENCE_INTERFACE_CALLBACK_FIELD, operation
+                                    .getName(), Field.Store.YES, 
Field.Index.ANALYZED));
 
-                        }
+                            }
+                        } 
 
                     }
 

Modified: 
tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentTypeDocumentProcessor.java
URL: 
http://svn.apache.org/viewvc/tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentTypeDocumentProcessor.java?rev=951561&r1=951560&r2=951561&view=diff
==============================================================================
--- 
tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentTypeDocumentProcessor.java
 (original)
+++ 
tuscany/sca-java-1.x/trunk/modules/domain-search/src/main/java/org/apache/tuscany/sca/domain/search/impl/ComponentTypeDocumentProcessor.java
 Fri Jun  4 20:39:35 2010
@@ -128,11 +128,13 @@ public class ComponentTypeDocumentProces
 
                         }
 
-                        for (Operation operation : 
interfaceContract.getCallbackInterface().getOperations()) {
+                        if (interfaceContract.getCallbackInterface() != null) {
+                            for (Operation operation : 
interfaceContract.getCallbackInterface().getOperations()) {
 
-                            referenceDoc.add(new 
Field(SearchFields.REFERENCE_INTERFACE_CALLBACK_FIELD, operation
-                                .getName(), Field.Store.YES, 
Field.Index.ANALYZED));
+                                referenceDoc.add(new 
Field(SearchFields.REFERENCE_INTERFACE_CALLBACK_FIELD, operation
+                                    .getName(), Field.Store.YES, 
Field.Index.ANALYZED));
 
+                            }
                         }
 
                     }


Reply via email to