Author: antelder
Date: Sun Mar 6 09:12:37 2011
New Revision: 1078431
URL: http://svn.apache.org/viewvc?rev=1078431&view=rev
Log:
Minor performance enhancement - look up the mapper once instead of each time
Modified:
tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCABindingProviderFactory.java
tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCAServiceBindingProvider.java
Modified:
tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCABindingProviderFactory.java
URL:
http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCABindingProviderFactory.java?rev=1078431&r1=1078430&r2=1078431&view=diff
==============================================================================
---
tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCABindingProviderFactory.java
(original)
+++
tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCABindingProviderFactory.java
Sun Mar 6 09:12:37 2011
@@ -21,8 +21,10 @@ package org.apache.tuscany.sca.binding.s
import org.apache.tuscany.sca.assembly.SCABinding;
import org.apache.tuscany.sca.core.ExtensionPointRegistry;
+import org.apache.tuscany.sca.core.UtilityExtensionPoint;
import org.apache.tuscany.sca.provider.BindingProviderFactory;
import org.apache.tuscany.sca.provider.ReferenceBindingProvider;
+import org.apache.tuscany.sca.provider.SCABindingMapper;
import org.apache.tuscany.sca.provider.ServiceBindingProvider;
import org.apache.tuscany.sca.runtime.RuntimeEndpoint;
import org.apache.tuscany.sca.runtime.RuntimeEndpointReference;
@@ -35,9 +37,12 @@ import org.apache.tuscany.sca.runtime.Ru
public class RuntimeSCABindingProviderFactory implements
BindingProviderFactory<SCABinding> {
private ExtensionPointRegistry extensionPoints;
+ private SCABindingMapper scaBindingMapper;
public RuntimeSCABindingProviderFactory(ExtensionPointRegistry
extensionPoints) {
this.extensionPoints = extensionPoints;
+ UtilityExtensionPoint utilities =
extensionPoints.getExtensionPoint(UtilityExtensionPoint.class);
+ this.scaBindingMapper = utilities.getUtility(SCABindingMapper.class);
}
public ReferenceBindingProvider
createReferenceBindingProvider(RuntimeEndpointReference endpointReference) {
@@ -45,7 +50,7 @@ public class RuntimeSCABindingProviderFa
}
public ServiceBindingProvider createServiceBindingProvider(RuntimeEndpoint
endpoint) {
- return new RuntimeSCAServiceBindingProvider(extensionPoints, endpoint);
+ return new RuntimeSCAServiceBindingProvider(scaBindingMapper,
endpoint);
}
public Class<SCABinding> getModelType() {
Modified:
tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCAServiceBindingProvider.java
URL:
http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCAServiceBindingProvider.java?rev=1078431&r1=1078430&r2=1078431&view=diff
==============================================================================
---
tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCAServiceBindingProvider.java
(original)
+++
tuscany/sca-java-2.x/trunk/modules/binding-sca-runtime/src/main/java/org/apache/tuscany/sca/binding/sca/provider/RuntimeSCAServiceBindingProvider.java
Sun Mar 6 09:12:37 2011
@@ -19,10 +19,6 @@
package org.apache.tuscany.sca.binding.sca.provider;
-import java.util.Iterator;
-
-import org.apache.tuscany.sca.core.ExtensionPointRegistry;
-import org.apache.tuscany.sca.core.UtilityExtensionPoint;
import org.apache.tuscany.sca.interfacedef.InterfaceContract;
import org.apache.tuscany.sca.invocation.InvocationChain;
import org.apache.tuscany.sca.invocation.InvokerAsyncResponse;
@@ -47,13 +43,10 @@ public class RuntimeSCAServiceBindingPro
private RuntimeComponentService service;
private ServiceBindingProvider distributedProvider;
- private SCABindingMapper scaBindingMapper;
- public RuntimeSCAServiceBindingProvider(ExtensionPointRegistry
extensionPoints, RuntimeEndpoint endpoint) {
+ public RuntimeSCAServiceBindingProvider(SCABindingMapper scaBindingMapper,
RuntimeEndpoint endpoint) {
this.endpoint = endpoint;
this.service = (RuntimeComponentService)endpoint.getService();
- UtilityExtensionPoint utilities =
extensionPoints.getExtensionPoint(UtilityExtensionPoint.class);
- this.scaBindingMapper = utilities.getUtility(SCABindingMapper.class);
// if there is potentially a wire to this service that crosses the
node boundary
// then we need to create a remote endpoint
