This is an automated email from the ASF dual-hosted git repository.
toulmean pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tuweni.git
The following commit(s) were added to refs/heads/master by this push:
new 63343fa Use a lowercase hex encoding when performing a toString from
the bytes module.
new 1880a77 Merge pull request #41 from rojotek/lowercase-hex
63343fa is described below
commit 63343fafabc0f5adc0e3c02cfc05e59f07568b4c
Author: Rob Dawson <[email protected]>
AuthorDate: Mon Nov 18 13:34:27 2019 +1000
Use a lowercase hex encoding when performing a toString from the bytes
module.
---
.../main/java/org/apache/tuweni/bytes/AbstractBytes.java | 2 +-
.../java/org/apache/tuweni/bytes/CommonBytesTests.java | 2 +-
.../org/apache/tuweni/bytes/ConcatenatedBytesTest.java | 16 ++++++++--------
.../java/org/apache/tuweni/crypto/SECP256K1Test.java | 2 +-
.../tuweni/devp2p/v5/packet/FindNodeMessageTest.kt | 2 +-
.../apache/tuweni/devp2p/v5/packet/RandomMessageTest.kt | 2 +-
.../tuweni/devp2p/v5/packet/WhoAreYouMessageTest.kt | 2 +-
7 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/bytes/src/main/java/org/apache/tuweni/bytes/AbstractBytes.java
b/bytes/src/main/java/org/apache/tuweni/bytes/AbstractBytes.java
index 7c19c7a..8f7aee2 100644
--- a/bytes/src/main/java/org/apache/tuweni/bytes/AbstractBytes.java
+++ b/bytes/src/main/java/org/apache/tuweni/bytes/AbstractBytes.java
@@ -18,7 +18,7 @@ package org.apache.tuweni.bytes;
*/
public abstract class AbstractBytes implements Bytes {
- static final char[] HEX_CODE = "0123456789ABCDEF".toCharArray();
+ static final char[] HEX_CODE = "0123456789abcdef".toCharArray();
/**
* Compare this value and the provided one for equality.
diff --git a/bytes/src/test/java/org/apache/tuweni/bytes/CommonBytesTests.java
b/bytes/src/test/java/org/apache/tuweni/bytes/CommonBytesTests.java
index b387ba5..f3fcf28 100644
--- a/bytes/src/test/java/org/apache/tuweni/bytes/CommonBytesTests.java
+++ b/bytes/src/test/java/org/apache/tuweni/bytes/CommonBytesTests.java
@@ -518,7 +518,7 @@ abstract class CommonBytesTests {
assertEquals("0x", Bytes.EMPTY.toString());
assertEquals("0x01", of(1).toString());
- assertEquals("0x0AFF03", of(0x0a, 0xff, 0x03).toString());
+ assertEquals("0x0aff03", of(0x0a, 0xff, 0x03).toString());
}
@Test
diff --git
a/bytes/src/test/java/org/apache/tuweni/bytes/ConcatenatedBytesTest.java
b/bytes/src/test/java/org/apache/tuweni/bytes/ConcatenatedBytesTest.java
index b4489b1..bc6ef02 100644
--- a/bytes/src/test/java/org/apache/tuweni/bytes/ConcatenatedBytesTest.java
+++ b/bytes/src/test/java/org/apache/tuweni/bytes/ConcatenatedBytesTest.java
@@ -63,7 +63,7 @@ class ConcatenatedBytesTest {
void shouldReadConcatenatedValue() {
Bytes bytes = wrap(fromHexString("0x01234567"),
fromHexString("0x89ABCDEF"));
assertEquals(8, bytes.size());
- assertEquals("0x0123456789ABCDEF", bytes.toHexString());
+ assertEquals("0x0123456789abcdef", bytes.toHexString());
}
@Test
@@ -74,16 +74,16 @@ class ConcatenatedBytesTest {
fromHexString("0x01234567"),
fromHexString("0x89ABCDEF"));
assertEquals("0x", bytes.slice(4, 0).toHexString());
- assertEquals("0x0123456789ABCDEF0123456789ABCDEF", bytes.slice(0,
16).toHexString());
+ assertEquals("0x0123456789abcdef0123456789abcdef", bytes.slice(0,
16).toHexString());
assertEquals("0x01234567", bytes.slice(0, 4).toHexString());
assertEquals("0x0123", bytes.slice(0, 2).toHexString());
assertEquals("0x6789", bytes.slice(3, 2).toHexString());
- assertEquals("0x89ABCDEF", bytes.slice(4, 4).toHexString());
- assertEquals("0xABCD", bytes.slice(5, 2).toHexString());
- assertEquals("0xEF012345", bytes.slice(7, 4).toHexString());
+ assertEquals("0x89abcdef", bytes.slice(4, 4).toHexString());
+ assertEquals("0xabcd", bytes.slice(5, 2).toHexString());
+ assertEquals("0xef012345", bytes.slice(7, 4).toHexString());
assertEquals("0x01234567", bytes.slice(8, 4).toHexString());
- assertEquals("0x456789ABCDEF", bytes.slice(10, 6).toHexString());
- assertEquals("0x89ABCDEF", bytes.slice(12, 4).toHexString());
+ assertEquals("0x456789abcdef", bytes.slice(10, 6).toHexString());
+ assertEquals("0x89abcdef", bytes.slice(12, 4).toHexString());
}
@Test
@@ -94,6 +94,6 @@ class ConcatenatedBytesTest {
fromHexString("0x01234567"),
fromHexString("0x89ABCDEF"));
assertEquals(24, bytes.size());
- assertEquals("0x0123456789ABCDEF0123456789ABCDEF0123456789ABCDEF",
bytes.toHexString());
+ assertEquals("0x0123456789abcdef0123456789abcdef0123456789abcdef",
bytes.toHexString());
}
}
diff --git a/crypto/src/test/java/org/apache/tuweni/crypto/SECP256K1Test.java
b/crypto/src/test/java/org/apache/tuweni/crypto/SECP256K1Test.java
index f8e3729..5945083 100644
--- a/crypto/src/test/java/org/apache/tuweni/crypto/SECP256K1Test.java
+++ b/crypto/src/test/java/org/apache/tuweni/crypto/SECP256K1Test.java
@@ -165,7 +165,7 @@ class SECP256K1Test {
void testEncodeSignature() {
SECP256K1.Signature signature = new SECP256K1.Signature((byte) 0,
BigInteger.ONE, BigInteger.TEN);
assertEquals(
-
"0x0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000A00",
+
"0x0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000a00",
signature.bytes().toString());
}
diff --git
a/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/FindNodeMessageTest.kt
b/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/FindNodeMessageTest.kt
index 551bd27..d862f9a 100644
---
a/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/FindNodeMessageTest.kt
+++
b/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/FindNodeMessageTest.kt
@@ -23,7 +23,7 @@ class FindNodeMessageTest {
@Test
fun encodeCreatesValidBytesSequence() {
- val expectedEncodingResult = "0xCA88C6E32C5E89CAA75480"
+ val expectedEncodingResult = "0xca88c6e32c5e89caa75480"
val requestId = Bytes.fromHexString("0xC6E32C5E89CAA754")
val message = FindNodeMessage(requestId)
diff --git
a/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/RandomMessageTest.kt
b/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/RandomMessageTest.kt
index ac125b9..c3c6c20 100644
---
a/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/RandomMessageTest.kt
+++
b/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/RandomMessageTest.kt
@@ -24,7 +24,7 @@ class RandomMessageTest {
@Test
fun encodeCreatesValidBytesSequence() {
val expectedEncodingResult =
-
"0xB53CCF732982B8E950836D1E02898C8B38CFDBFDF86BC65C8826506B454E14618EA73612A0F5582C130FF666"
+
"0xb53ccf732982b8e950836d1e02898c8b38cfdbfdf86bc65c8826506b454e14618ea73612a0f5582c130ff666"
val data = Bytes.fromHexString(expectedEncodingResult)
val message = RandomMessage(UdpMessage.authTag(), data)
diff --git
a/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/WhoAreYouMessageTest.kt
b/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/WhoAreYouMessageTest.kt
index 12ad2d2..0cd3e8d 100644
---
a/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/WhoAreYouMessageTest.kt
+++
b/devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/packet/WhoAreYouMessageTest.kt
@@ -24,7 +24,7 @@ class WhoAreYouMessageTest {
@Test
fun encodeCreatesValidBytesSequence() {
val expectedEncodingResult =
-
"0xEF8C05D038D54B1ACB9A2A83C480A0C3B548CA063DA57BC9DE93340360AF32815FC8D0B2F053B3CB7918ABBB291A5180"
+
"0xef8c05d038d54b1acb9a2a83c480a0c3b548ca063da57bc9de93340360af32815fc8d0b2f053b3cb7918abbb291a5180"
val authTag = Bytes.fromHexString("0x05D038D54B1ACB9A2A83C480")
val nonce =
Bytes.fromHexString("0xC3B548CA063DA57BC9DE93340360AF32815FC8D0B2F053B3CB7918ABBB291A51")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
