This is an automated email from the ASF dual-hosted git repository.
toulmean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-tuweni.git
The following commit(s) were added to refs/heads/main by this push:
new 5767c17 Do not convert identifier to lower case when parsing file in
FileBackedFingerprintRepository
new be0d1a8 Merge pull request #353 from
usmansaleem/filebackedrepo_identifier_case
5767c17 is described below
commit 5767c173191331bf5939da1c75acdc6f95114239
Author: Usman Saleem <[email protected]>
AuthorDate: Wed Jan 5 19:09:44 2022 +1000
Do not convert identifier to lower case when parsing file in
FileBackedFingerprintRepository
---
.../tuweni/net/tls/FileBackedFingerprintRepository.java | 2 +-
.../net/tls/FileBackedFingerprintRepositoryTest.java | 17 +++++++++++++++++
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git
a/net/src/main/java/org/apache/tuweni/net/tls/FileBackedFingerprintRepository.java
b/net/src/main/java/org/apache/tuweni/net/tls/FileBackedFingerprintRepository.java
index 0f1c3ac..69ae1e6 100644
---
a/net/src/main/java/org/apache/tuweni/net/tls/FileBackedFingerprintRepository.java
+++
b/net/src/main/java/org/apache/tuweni/net/tls/FileBackedFingerprintRepository.java
@@ -158,7 +158,7 @@ final class FileBackedFingerprintRepository implements
FingerprintRepository {
if (segments.length != 2) {
throw new IOException("Invalid line");
}
- String identifier = segments[0].toLowerCase();
+ String identifier = segments[0];
String fingerprintString = segments[1].trim().replace(":", "");
Bytes fingerprint;
try {
diff --git
a/net/src/test/java/org/apache/tuweni/net/tls/FileBackedFingerprintRepositoryTest.java
b/net/src/test/java/org/apache/tuweni/net/tls/FileBackedFingerprintRepositoryTest.java
index 9af1504..2cc1cc8 100644
---
a/net/src/test/java/org/apache/tuweni/net/tls/FileBackedFingerprintRepositoryTest.java
+++
b/net/src/test/java/org/apache/tuweni/net/tls/FileBackedFingerprintRepositoryTest.java
@@ -52,6 +52,23 @@ class FileBackedFingerprintRepositoryTest {
}
@Test
+ void testCaseSensitiveIdentifier(@TempDirectory Path tempFolder) throws
IOException {
+ Path repoFile = tempFolder.resolve("repo");
+ String identifier1 = "foo";
+ String identifier2 = "Foo";
+
+ Bytes fingerprint1 = generateFingerprint();
+ Bytes fingerprint2 = generateFingerprint();
+
+ String content = String.format("%s %s%n%s %s", identifier1, fingerprint1,
identifier2, fingerprint2);
+ Files.writeString(repoFile, content);
+
+ FileBackedFingerprintRepository repo = new
FileBackedFingerprintRepository(repoFile);
+ assertTrue(repo.contains(identifier1, fingerprint1));
+ assertTrue(repo.contains(identifier2, fingerprint2));
+ }
+
+ @Test
FileBackedFingerprintRepository testAddingNewFingerprint(@TempDirectory Path
tempFolder) throws IOException {
FileBackedFingerprintRepository repo = new
FileBackedFingerprintRepository(tempFolder.resolve("repo"));
Bytes fingerprint = generateFingerprint();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
