This is an automated email from the ASF dual-hosted git repository.

toulmean pushed a commit to branch fix_decrypt_seal
in repository https://gitbox.apache.org/repos/asf/incubator-tuweni.git

commit 896b982862223786e50341f52cb4d00ec39b475b
Author: Antoine Toulme <[email protected]>
AuthorDate: Thu Mar 23 21:04:01 2023 -0700

    Fix issue #524
---
 crypto/src/main/java/org/apache/tuweni/crypto/sodium/Box.java     | 8 ++++----
 crypto/src/test/java/org/apache/tuweni/crypto/sodium/BoxTest.java | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/crypto/src/main/java/org/apache/tuweni/crypto/sodium/Box.java 
b/crypto/src/main/java/org/apache/tuweni/crypto/sodium/Box.java
index bcf023d6d..9d8e8b85b 100644
--- a/crypto/src/main/java/org/apache/tuweni/crypto/sodium/Box.java
+++ b/crypto/src/main/java/org/apache/tuweni/crypto/sodium/Box.java
@@ -1094,13 +1094,13 @@ public final class Box implements AutoCloseable {
    * Decrypt a sealed message using a given key.
    *
    * @param cipherText The cipher text to decrypt.
-   * @param sender The public key of the sender.
+   * @param receiver The public key of the receiver.
    * @param receiver The secret key of the receiver.
    * @return The decrypted data, or {@code null} if verification failed.
    */
   @Nullable
-  public static byte[] decryptSealed(byte[] cipherText, PublicKey sender, 
SecretKey receiver) {
-    if (sender.isDestroyed()) {
+  public static byte[] decryptSealed(byte[] cipherText, PublicKey receiverPk, 
SecretKey receiver) {
+    if (receiver.isDestroyed()) {
       throw new IllegalArgumentException("SecretKey has been destroyed");
     }
     long sealbytes = Sodium.crypto_box_sealbytes();
@@ -1117,7 +1117,7 @@ public final class Box implements AutoCloseable {
             clearText,
             cipherText,
             cipherText.length,
-            sender.value.pointer(),
+            receiverPk.value.pointer(),
             receiver.value.pointer());
     if (rc == -1) {
       return null;
diff --git a/crypto/src/test/java/org/apache/tuweni/crypto/sodium/BoxTest.java 
b/crypto/src/test/java/org/apache/tuweni/crypto/sodium/BoxTest.java
index ed4e7a2ff..16d7c4fe7 100644
--- a/crypto/src/test/java/org/apache/tuweni/crypto/sodium/BoxTest.java
+++ b/crypto/src/test/java/org/apache/tuweni/crypto/sodium/BoxTest.java
@@ -89,9 +89,9 @@ class BoxTest {
 
   @Test
   void encryptDecryptSealed() {
-    Box.KeyPair keyPair = Box.KeyPair.random();
-    Bytes encrypted = Box.encryptSealed(Bytes.fromHexString("deadbeef"), 
keyPair.publicKey());
-    Bytes decrypted = Box.decryptSealed(encrypted, keyPair.publicKey(), 
keyPair.secretKey());
+    Box.KeyPair receiver = Box.KeyPair.random();
+    Bytes encrypted = Box.encryptSealed(Bytes.fromHexString("deadbeef"), 
receiver.publicKey());
+    Bytes decrypted = Box.decryptSealed(encrypted, receiver.publicKey(), 
receiver.secretKey());
     assertEquals(Bytes.fromHexString("deadbeef"), decrypted);
   }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to