tqchen commented on a change in pull request #4274: [µTVM] Enable AutoTVM for
ARM STM32F746XX Boards
URL: https://github.com/apache/incubator-tvm/pull/4274#discussion_r343927217
##########
File path: src/runtime/micro/openocd_low_level_device.cc
##########
@@ -201,35 +192,21 @@ class OpenOCDLowLevelDevice final : public
LowLevelDevice {
socket_.SendCommand();
// Remove the breakpoint.
- socket_.cmd_builder() << "rbp " << ToDevPtr(breakpoint).cast_to<void*>();
+ socket_.cmd_builder() << "rbp " << breakpoint_addr.cast_to<void*>();
socket_.SendCommand();
}
- void SetStackTop(DevBaseOffset stack_top) {
- stack_top_ = DevPtr(base_addr_ + stack_top.value());
- }
-
- std::uintptr_t base_addr() const final {
- return base_addr_;
- }
-
- DevPtr stack_top() const {
- CHECK(stack_top_ != nullptr) << "stack top was never initialized";
- return stack_top_;
- }
-
const char* device_type() const final {
return "openocd";
}
private:
- /*! \brief base address of the micro device memory region */
- std::uintptr_t base_addr_;
- /*! \brief top of the stack section */
- DevPtr stack_top_;
/*! \brief socket used to communicate with the device through Tcl */
TclSocket socket_;
+ std::string server_addr_;
Review comment:
document the fields
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
