FrozenGene commented on issue #4277: [ARM][Topi] Improving Int8 Perf in Spatial Conv2D schedule. URL: https://github.com/apache/incubator-tvm/pull/4277#issuecomment-551362798 > @jackwish Yes, sharing code will be very helpful. For now, do you prefer changing schedule OR Legalize pass? > > Changing Schedule > > * (+) The change is contained to only one template. > * (-) Schedules are generally hard to understand. In general, I try to avoid complicating them. > > Legalize Pass > > * (+) The codebase might be cleaner (if one understands Relay passes). > * (+) Topi schedules are generally hard to understand. In general, I try to avoid complicating them. This avoids that. > * (-) Applies to all templates. For example, if I write a new template (like direct, winograd), legalize will upcast. > > I dont have any strong opinion. If someone is schedule guy, modify the schedule frequently, we apply it in schedule is better for them, because they could handle it whole in schedule. However, from the code viewpoint, I suggest adding in Pass. Because this should be applied in all templates. And for ARMv8.2, dot product instruction is better, could be done in legalize too.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
