tqchen commented on a change in pull request #4281: [RUTNIME] Support C++ RPC
URL: https://github.com/apache/incubator-tvm/pull/4281#discussion_r344506031
##########
File path: apps/cpp_rpc/rpc_env.cc
##########
@@ -164,8 +163,11 @@ void LinuxShared(const std::string output,
cmd += " " + *f;
}
cmd += " " + options;
- std::string executed_result = common::Execute(cmd);
- CHECK(executed_result.length() == 0) << executed_result;
+ std::string err_msg;
+ auto executed_status = common::Execute(cmd, err_msg);
+ if (executed_status) {
+ LOG(ERROR) << err_msg;
Review comment:
Use ```LOG(FATAL) << "RuntimeError: " << err_msg``` . This will allow us to
throw a specific RuntimeError in the python side, by default ERROR may not
throw an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
