comaniac commented on issue #4280: [tvm][runtime] A minimum runtime for 
external library
URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-553048433
 
 
   @tqchen could you help review again? Here is a short summary of the current 
runtime after your suggestions:
   
   * The runtime takes only one .so file including host and external kernels.
   * The runtime is now unified with `DSOModule` so backend developers don't 
need to implement their own runtime (and `GetFunction`) anymore. Instead, they 
need to unpack `TVMValue` in the generated kernels.
   * The 
[example](https://github.com/apache/incubator-tvm/pull/4280/files#diff-aab1542f9a9fec245df5ae78088f43ffR253)
 in this PR demonstrates a case that user backend will generate third-party 
library calls. This is applicable to runtime-less libraries such as MKL-DNN.
   * For the external backend that has a runtime engine such as TRT, we can 
still codegen external functions like [this 
example](https://github.com/apache/incubator-tvm/pull/4280/files#diff-aab1542f9a9fec245df5ae78088f43ffR27),
 construct the subgraph in that function, and invoke the TRT engine to execute 
it on the fly.
   
   We will refine the other codegen PR based on this one after merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to