yzhliu commented on a change in pull request #4331: [Codegen] remove fp16
function override for cuda
URL: https://github.com/apache/incubator-tvm/pull/4331#discussion_r346092177
##########
File path: src/codegen/literal/cuda_half_t.h
##########
@@ -76,7 +77,7 @@ class TVM_ALIGNED(2) half {
TVM_XINLINE explicit half(const uint8_t& value) { constructor(value); }
TVM_XINLINE explicit half(const int32_t& value) { constructor(value); }
TVM_XINLINE explicit half(const uint32_t& value) { constructor(value); }
- TVM_XINLINE explicit half(const int64_t& value) { constructor(value); }
+ TVM_XINLINE explicit half(const long long& value) { constructor(value); }
Review comment:
do I need to `#include <cstdint>` for `int64_t` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
