icemelon9 commented on issue #4323: [Contrib] Add MKL DNN option URL: https://github.com/apache/incubator-tvm/pull/4323#issuecomment-553992571 @soiferj No. If the USE_BLAS is OFF, we won't compile MKLDNN ops. See here in the cmake https://github.com/apache/incubator-tvm/pull/4323/files#diff-9e0c77365976363b16f3bdc58f95fb38R59 One proposal is that I remove `(NOT USE_BLAS STREQUAL "none")` in the condition but I won't add ${CBLAS_CONTRIB_SRC} into src list if USE_BLAS is OFF. So if we have conv2d contrib using MKLDNN in the future, we can still include that file in the src list. How does this sound?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
