tqchen commented on issue #4335: [Relay][WIP] ConvertLayout pass.
URL: https://github.com/apache/incubator-tvm/pull/4335#issuecomment-554175946
 
 
   I feel live patching the OpAttr is not a pattern we are looking for in here. 
It would be great if we can factor out some common logic between AlterOpLayout 
and ConvertLayout(e.g. a base class), so ConvertLayout can directly inject the 
necessary functions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to