jackwish commented on a change in pull request #4338: AutoTVM: selecting tuning 
templates when extracting task
URL: https://github.com/apache/incubator-tvm/pull/4338#discussion_r346720164
 
 

 ##########
 File path: python/tvm/autotvm/task/relay_integration.py
 ##########
 @@ -153,15 +154,25 @@ def extract_from_multiple_program(funcs, params, ops, 
target, target_host=None,
 
         logger.disabled = old_state
 
+    # convert *topi op to template key* map to *task name to template key* map
+    task_keys = dict()
 
 Review comment:
   > Is there any particular concern to use dict() instead of {} to create a 
dictionary?
   
   I think `dict()` is more easy to read... C++ guys...
   
   I agree with your comments generally, will update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to