zhiics commented on a change in pull request #4280: [TVM][RUNTIME] A minimum
example to generate external library wrappers for DSOModule
URL: https://github.com/apache/incubator-tvm/pull/4280#discussion_r347187399
##########
File path: include/tvm/runtime/module.h
##########
@@ -111,7 +111,7 @@ class Module : public ObjectRef {
*
* \endcode
*/
-class ModuleNode : public Object {
+class TVM_DLL ModuleNode : public Object {
Review comment:
@tqchen We added `TVM_DLL` so that the ExampleJsonModule can inherit it in
the test. It looks that this is also used by other classes like `DeviceAPI`
etc. Does this sound good? otherwise, please advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
