jackwish commented on issue #3949: [AutoTVM] Enhance tuning space of split URL: https://github.com/apache/incubator-tvm/pull/3949#issuecomment-556830400 Hi @comaniac , this is really interesting change. I have not read all the code, but may I ask that if the PR changes the split representation such that the *highest split* is left as `-1`, for example `["tile_co", "sp", [-1, 8]]`? I have some schedules extracting split factor like `CO, CI = cfg['tile_co'].size`, which seems to be broken by this PR. PS. I didn't verify all the patches, but the change leading to my concern is among these below. ``` 9e4f07b4695a8849590cdd46de662e3fa273d59b Enable miopen transpose convolution and fp16 support (#3952) 0482623e9c20518fac8e6ceb34a6552f674fed9b [Relay][TensorFlow] Add support for SquaredDifference (#3930) da039794cfc7c7d94855b0dc6f93248f13222c7f [AutoTVM] Enhance tuning space of split (#3949) e35e1cc2e8d6b14aae5c888b12205b85afc80bb2 trivial (#3954) 4b431c67fdc55062afa682fe3d4816bd02b9f7ec 1) Add EQ op to the deduce_bound and add unittests for the same (#3775) 2536465c2e274273344c5e67337fd3b4c252ec2f Vulkan2 Runtime API (#3849) 06aecc60ea55e10cc029ec4c2f3ff2fcc811c802 [VTA] RPC path update. (#3924) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
