jackwish edited a comment on issue #3859: [TOPI][AutoTVM] NHWC conv2d templates 
for ARM
URL: https://github.com/apache/incubator-tvm/pull/3859#issuecomment-557033246
 
 
   For the [CI sanity 
check](http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3859/5/pipeline)
 , I failed to reproduce it locally :(. And, I think the warning (as below) 
should be ignored because we are really using `cfg['compat'].val` as integer 
rather than bool.
   
   ```
   python3 -m pylint topi/python/topi --rcfile=/workspace/tests/lint/pylintrc
   
   Using config file /workspace/tests/lint/pylintrc
   
   ************* Module topi.arm_cpu.conv2d_spatial_pack
   
   topi/python/topi/arm_cpu/conv2d_spatial_pack.py:314: 
[R1706(consider-using-ternary), schedule_conv2d_spatial_pack_nhwc] Consider 
using ternary (oco if cfg['compat'].val else owo)
   
   topi/python/topi/arm_cpu/conv2d_spatial_pack.py:331: 
[R1706(consider-using-ternary), schedule_conv2d_spatial_pack_nhwc] Consider 
using ternary (oco if cfg['compat'].val else owo)
   
   
   
   --------------------------------------------------------------------
   
   Your code has been rated at 10.00/10 (previous run: 10.00/10, -0.00)
   ```
   
   I suggest to disable that warning @tqchen . Anyway, if disabling globally is 
too strong, I will disable it in this file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to