u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557047170 > Comments about json runtime. I would consider move the json runtime to > `apps/extern_runtime` to allow us to write examples even in python. It would be great to see examples like: > > ```python > mod = DSOModule() > mod.import_module(JSONExampleModule()) > > mod.export_library("xyz.so") > > mod = tvm.module.load("xyz.so") > # run that he code that can uses functions in the JSONExampleModule > ``` > > The main goal is to provide readers an easy reference point about how to add their own runtimes. Isn't it also to provide a standardized structure for them to integrate their runtimes ? Are we expecting such integrations to happen via the 3rd party directory mechanism which is currently really for build dependencies. Giving an example integration shows how it can be done, providing with an initial location and standard mechanism for the simple toy integration. In my opinion a simple integration should provide a template to follow. Putting this in examples appears to suggest that folks can do what they want with the 3rd party runtime integration. > > As a followup, we can add docs/dev/custom_codegen_runtime.rst that introduces both the compile to DSOModule method and the extern json runtime example, with reference to the folder. I'm puzzled by this direction. What is missing for me in this pull request is actually a directory structure or something that indicates where and how custom run times can go in. This suggests that we could have a full custom run time sitting in the app / examples folder ? Instead shouldn't a custom run time really be in the 3rd party folder rather than sitting in the app folder or indeed under tvm/runtime/3rdparty/ or some such. Ramana
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
