inadob opened a new pull request #4395: [Relay][Frontend][TFlite] Add test for qnn_mul operator URL: https://github.com/apache/incubator-tvm/pull/4395 * Add a function to set the qnn output range wrt each elemwise operation. * Add comments warning for nonsense clamped output in the tflite/tvm results comparison. A separate output range for each operation has to be defined since if we specify a single range that to work in general for all elemwise operations it will result in a lower accuracy and clamped outputs when we test those elemwise operators whose possible output range is much smaller. The warning comments point to the the problem with clamping that can be easily overlooked because once tflite clipps the ouput tensor values to 0 or 255 then that output tensor get consumed by tvm and as a result the tflite_ouput and tvm_ouput are the same... so they pass the assertion. The only things that the future testwriter has to do are: 1) set all the input tensors to [-100; 100] float 32 in the tf graph 2) define the range of the output tensor with respect to the particular operation. 3) pass the uint8 input data to the graph in [0; 255]
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
