comaniac commented on a change in pull request #4151: [AutoTVM] Added an 
autotuning Config Library to store autotune results
URL: https://github.com/apache/incubator-tvm/pull/4151#discussion_r349293137
 
 

 ##########
 File path: python/tvm/autotvm/tuner/tuner.py
 ##########
 @@ -86,8 +87,7 @@ def update(self, inputs, results):
             result for measurement
         """
 
-
-    def tune(self, n_trial, measure_option, early_stopping=None, callbacks=()):
+    def tune(self, n_trial, measure_option, early_stopping=None, callbacks=(), 
allow_skipping=True):
 
 Review comment:
   I think the default value of `allow_skipping` should be `False`, which means 
users have to intentionally skip tasks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to