junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349348399
########## File path: include/tvm/runtime/container.h ########## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm/runtime/container.h + * \brief Common POD(plain old data) container types. + */ +#ifndef TVM_RUNTIME_CONTAINER_H_ +#define TVM_RUNTIME_CONTAINER_H_ +#include <dmlc/logging.h> +#include <tvm/runtime/memory.h> +#include <tvm/runtime/object.h> + +#include <initializer_list> +#include <type_traits> +#include <utility> +#include <vector> + +namespace tvm { +namespace runtime { + +/*! + * \brief Base template for classes with array like memory layout. + * + * It provides general methods to access the memory. The memory + * layout is ArrayType + [ElemType]. The alignment of ArrayType + * and ElemType is handled by the memory allocator. + * + * \tparam ArrayType + * \tparam ElemType + */ +template <typename ArrayType, typename ElemType> +class InplaceArrayBase { + public: + /*! + * \brief Replace the elements in the array. + * + * \tparam Iterator Iterator type of the array. + * \param begin The begin iterator. + * \param end The end iterator. + */ + template <typename Iterator> + void assign(Iterator begin, Iterator end) { + size_t num_elems = std::distance(begin, end); + auto it = begin; + for (size_t i = 0; i < num_elems; ++i) { + void* field_ptr = AddressOf(i); + new (field_ptr) ElemType(*it); + ++it; + } + Self()->set_size(num_elems); + } + + /*! + * \brief Replace the elements in the array. + * + * \param init The initializer list of elements. + */ + void assign(std::initializer_list<ElemType> init) { + assign(init.begin(), init.end()); + } + + /*! + * \brief Access element at index + * \param idx The index of the element. + * \return Const reference to ElemType at the index. + */ + const ElemType& operator[](size_t idx) const { + size_t size = Self()->size(); + CHECK_LT(idx, size) << "Index " << idx << " out of bounds " << size << "\n"; + return *(reinterpret_cast<ElemType*>(AddressOf(idx))); + } + + /*! + * \brief Access element at index + * \param idx The index of the element. + * \return Reference to ElemType at the index. + */ + ElemType& operator[](size_t idx) { return this->operator[](idx); } + + /*! + * \brief Push a value to the end of the array. + * + * \param val The value to be added. + */ + void push_back(const ElemType& val) { + size_t size = Self()->size(); + CHECK_LT(size, Self()->capacity()); + (*this)[size] = val; + Self()->set_size(size + 1); + } + + /*! + * \brief Construct a value in the end of the array. + * + * \tparam Args Type parameters of the arguments. + * \param args Arguments used to construct the new value. + */ + template <typename... Args> + void emplace_back(Args&&... args) { + size_t size = Self()->size(); + CHECK_LT(size, Self()->capacity()); + EmplaceInit(size, std::forward<Args>(args)...); + Self()->set_size(size + 1); + } + + /*! + * \brief Destroy the Inplace Array Base object + */ + ~InplaceArrayBase() { + if (!IsPOD()) { + size_t size = Self()->size(); + for (size_t i = 0; i < size; ++i) { + ElemType* fp = reinterpret_cast<ElemType*>(AddressOf(i)); + fp->ElemType::~ElemType(); + } + } + } + + protected: + /*! + * \brief Construct a value in place with the arguments. + * + * \tparam Args Type parameters of the arguments. + * \param idx Index of the element. + * \param args Arguments to construct the new value. + */ + template <typename... Args> + void EmplaceInit(size_t idx, Args&&... args) { + size_t size = Self()->size(); + CHECK_LT(size, Self()->capacity()) << "InplaceArray out of capacity\n"; + void* field_ptr = AddressOf(size); + new (field_ptr) ElemType(std::forward<Args>(args)...); + Self()->set_size(size + 1); + } + + private: + /*! + * \brief If the ElemType is Plain Old Data. + */ + inline bool IsPOD() const { + return std::is_standard_layout<ElemType>::value && + std::is_trivial<ElemType>::value; + } + + /*! + * \brief Return the self object for the array. + * + * \return Pointer to ArrayType. + */ + inline ArrayType* Self() const { + return static_cast<ArrayType*>(const_cast<InplaceArrayBase*>(this)); + } + + /*! + * \brief Return the raw pointer to the element at idx. + * + * \param idx The index of the element. + * \return Raw pointer to the element. + */ + void* AddressOf(size_t idx) const { + size_t kDataStart = sizeof(ArrayType); Review comment: I am a bit concerned about the alignment here...Shall we have some alignment tweaks here to make sure the inplace new work properly? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
