u99127 commented on a change in pull request #4274: [µTVM] Enable AutoTVM for ARM STM32F746XX Boards URL: https://github.com/apache/incubator-tvm/pull/4274#discussion_r349843771
########## File path: python/tvm/micro/device/arm/stm32f746xx.py ########## @@ -0,0 +1,123 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Compilation and config definitions for ARM STM32F746XX devices""" +from .. import create_micro_lib_base, register_device + +DEVICE_ID = "arm.stm32f746xx" +TOOLCHAIN_PREFIX = "arm-none-eabi-" + +def create_micro_lib(obj_path, src_path, lib_type, options=None): + """Wrapper over `create_micro_lib_base` to add device-specific options + + Parameters + ---------- + obj_path : str + path to generated object file + + src_path : str + path to source file + + lib_type : micro.LibType + whether to compile a MicroTVM runtime or operator library + + options : Optional[List[str]] + additional options to pass to GCC + """ + if options is None: + options = [] + options += [ + "-mcpu=cortex-m7", + "-mlittle-endian", + "-mfloat-abi=hard", + "-mfpu=fpv5-sp-d16", + "-mthumb", + "-gdwarf-5", + ] + create_micro_lib_base( + obj_path, src_path, TOOLCHAIN_PREFIX, DEVICE_ID, lib_type, options=options) + + +def default_config(server_addr, server_port): + """Generates a default configuration for ARM STM32F746XX devices + + Parameters + ---------- + server_addr : str + address of OpenOCD server to connect to + + server_port : int + port of OpenOCD server to connect to + + Return + ------ + config : Dict[str, Any] + MicroTVM config dict for this device + """ + return { + "device_id": DEVICE_ID, + "toolchain_prefix": TOOLCHAIN_PREFIX, + # + # [Device Memory Layout] + # RAM (rwx) : START = 0x20000000, LENGTH = 320K + # FLASH (rx) : START = 0x8000000, LENGTH = 1024K + # + "mem_layout": { + "text": { + "start": 0x20000180, + "size": 20480, + }, + "rodata": { + "start": 0x20005180, + "size": 20480, + }, + "data": { + "start": 0x2000a180, + "size": 768, + }, + "bss": { + "start": 0x2000a480, + "size": 768, + }, + "args": { + "start": 0x2000a780, + "size": 1280, + }, + "heap": { + "start": 0x2000ac80, + "size": 262144, + }, + "workspace": { + "start": 0x2004ac80, + "size": 20480, + }, + "stack": { + "start": 0x2004fc80, + "size": 80, + }, + }, Review comment: My expectation is that the main thing that will vary between the boards is: - Architectural options to provide (-mcpu, -mfpu, -mfloat-abi) - Linker Memory Maps. Both of which can be specified in the form of input text files or dictionaries to be consumed ? It also means that the code that creates the object doesn't need to be duplicated across devices ... Might be a little more complex to get done , but it means that the longer term refactor is a bit easier as we don't have to make repeated code changes in multiple places . i.e. something like arm/common/yourfavfilename.py arm/board_name/configuration_dictionaries. regards Ramana ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
