tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject
POD container type
URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349939425
##########
File path: include/tvm/runtime/memory.h
##########
@@ -124,11 +145,69 @@ class SimpleObjAllocator :
};
};
+// Array allocator that uses new/delete.
+class ArrayObjAllocator :
+ public ObjAllocatorBase<ArrayObjAllocator> {
+ public:
+ template<typename ArrayType, typename ElemType>
+ class Handler {
Review comment:
Let us move rename it as ArrayHandler and move it into SimpleObjAllocator.
Rationale: In the future, we want to be able to create different Allocators,
and call make_inplace_array_object in these allocators. It is easier to have a
single allocator object for both array object and normal objects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
