masahi commented on a change in pull request #4418: [RUNTIME] Add cudnn conv3d
URL: https://github.com/apache/incubator-tvm/pull/4418#discussion_r350001599
 
 

 ##########
 File path: tests/python/contrib/test_cudnn.py
 ##########
 @@ -72,6 +72,67 @@ def verify():
 
     verify()
 
 
 Review comment:
   can you modify this verify() function for cudnn 2D to make sure that output 
is correct? You can use 
[conv2d_nchw_python](https://github.com/apache/incubator-tvm/blob/master/topi/python/topi/testing/conv2d_nchw_python.py#L87)
 function. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to