tmoreau89 commented on a change in pull request #4392: [VTA] Enable streamlined
GEMM execution
URL: https://github.com/apache/incubator-tvm/pull/4392#discussion_r350933387
##########
File path: vta/hardware/chisel/src/main/scala/core/TensorGemm.scala
##########
@@ -126,8 +145,7 @@ class MatrixVectorMultiplication(implicit p: Parameters)
extends Module {
})
val dot = Seq.fill(size)(
Module(new DotProduct(aBits = inpBits, bBits = wgtBits, size)))
- val acc = Seq.fill(size)(
- Module(new Pipe(UInt(accBits.W), latency = log2Ceil(size) + 1)))
+ val acc = Seq.fill(size)(Module(new Pipe(UInt(accBits.W), latency = 2)))
Review comment:
Thanks for the explanation; totally makes sense. Can you add what you
explained as a code comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
